Add future.v7_normalizeFormMethod flag #10207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a future flag to normalize/align
useNavigation().formMethod
anduseFetcher().formMethod
with Remix.We want our API to behave like
fetch()
- it can accept lowercase or uppercase, but exposes the method back to you as a normalized uppercase method:So this means that both
<Form method="post">
and<Form method="POST">
should result inuseNavigation().formMethod === "POST"
.We inadvertently shipped lowercase
useNavigation
/useFetcher
values in 6.4, and only noticed the inconsistency when we went to deprecateuseTransition
in Remix which used uppercase. Therefore, we're putting this behind a future flag tro avoid breaking apps, and in Remix v2/React Router v7 we'll move to uppercase as the default.