-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dogfooding] Create website deploy previews for PRs using odo deploy
#6871
[Dogfooding] Create website deploy previews for PRs using odo deploy
#6871
Conversation
Skipping CI for Draft Pull Request. |
🔨 Deploy Preview deleted from internal cluster!
|
8b5f479
to
93aa8bc
Compare
93aa8bc
to
5a4a4e5
Compare
f35cbe4
to
5c31777
Compare
5c31777
to
c5d0a58
Compare
c5d0a58
to
c93b139
Compare
odo deploy
for the websiteodo deploy
d1821b8
to
0fb165f
Compare
odo deploy
odo deploy
…bsite The goal is to leverage this for creating PR deploy previews in an automated way.
We are using a robot account on quay.io, which requires specific permissions per repository name, which cannot be dynamic in this case. Since we are scoping everything per namespace, it should be fine.
0fb165f
to
0a3d2dc
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Reported in #6876 /override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests |
@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Not related - issue reported in #6894 /override OpenShift-Integration-tests/OpenShift-Integration-tests |
@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test odo-ocp4.13-lp-interop-images |
What type of PR is this:
/area testing
What does this PR do / why we need it:
This is a follow-up to the Dogfooding idea started with #6564
I wanted to take this opportunity to try odo as an outer-loop tool from a user perspective.
This PR adds a 'deploy' command to the website Devfile, and adds a GitHub Workflow that is triggered on PR events, and uses this Devfile to run
odo deploy
against our internal Kubernetes cluster, in order to create Deploy Previews for PRs (similar to what Netlify currently does).Once a PR is open, a dedicated namespace is created, and
odo deploy
is run against it. If deployment is successful (and the preview URL is reachable), a comment with the preview URL is automatically added to the PR.Once a PR is closed, the dedicated namespace is deleted.
NOTE: for security purposes, PRs from external forks will need a manual review and approval to be deployed (because this operation requires access to the GitHub Repository Secrets).
Examples of such PRs:
Which issue(s) this PR fixes:
DevTools week idea.
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
You should be able to run
odo deploy
from thedocs/website
folder.Note that this leverages the Image Name as selector feature to keep the Devfile portable. That is, the container image used in the image component is relative, and will be substituted in all matching components accordingly. For this to work, you need to set the
ImageRegistry
preference, e.g.: