Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dogfood odo for working on the website #6564

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Dogfood odo for working on the website #6564

merged 3 commits into from
Feb 2, 2023

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Feb 2, 2023

What type of PR is this:
/area documentation

What does this PR do / why we need it:
While working on #6562, I thought it would be interesting to eat our own food when working on the website.
I wanted to iterate locally with odo and Podman, hence this PR.
We can improve the devfile.yaml later on to cover more things like outer-loop.

Which issue(s) this PR fixes:
—

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

cd docs/website
ODO_EXPERIMENTAL_MODE=t odo dev --platform=podman

rm3l added 3 commits February 2, 2023 12:17
@rm3l
Add 'devfile.yaml' for working on the website
673c7f8
@rm3l
Git-ignore the '.odo' folder
1dc9884
@rm3l
Make Docusaurus listen on all interfaces
3da8239 
By default, Docusaurus would listen only on the loopback interface,
which does not work with Podman at this time (see [1]).

[1] redhat-developer#6510 (comment)
@openshift-ci openshift-ci bot added the area/documentation Issues or PRs related to documentation or the 'odo.dev' website label Feb 2, 2023
@openshift-ci openshift-ci bot requested review from feloy and kadel February 2, 2023 11:28
@netlify
Copy link

netlify bot commented Feb 2, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 3da8239
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63db9e62c528dd0008853219
😎 Deploy Preview https://deploy-preview-6564--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Feb 2, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 2, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 2, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@rm3l rm3l requested a review from valaparthvi February 2, 2023 11:39
@rm3l rm3l mentioned this pull request Feb 2, 2023
Merged
3 tasks
@odo-robot
Copy link

odo-robot bot commented Feb 2, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 2, 2023

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 2, 2023

Kubernetes Tests on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 2, 2023

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@rm3l
Copy link
Member Author

rm3l commented Feb 2, 2023

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override windows-integration-test/Windows-test

Not applicable here.

@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2023

@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests, windows-integration-test/Windows-test

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override windows-integration-test/Windows-test

Not applicable here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

feloy
feloy approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit c47a3d3 into redhat-developer:main Feb 2, 2023
@rm3l rm3l deleted the dogfood_odo_for_website_dev branch February 2, 2023 15:20
@rm3l rm3l mentioned this pull request Feb 3, 2023
Open
@rm3l rm3l added this to the v3.7.0 🚀 milestone Feb 15, 2023
@rm3l rm3l mentioned this pull request Jun 8, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@kadel kadel Awaiting requested review from kadel

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@feloy feloy

Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.7.0 🚀
Development

Successfully merging this pull request may close these issues.
3 participants
@rm3l @feloy @openshift-merge-robot