-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve website PR preview workflow #6907
Improve website PR preview workflow #6907
Conversation
…site' folder or in the Workflow itself While this allowed to test 'odo deploy', it makes more sense to avoid deploying the website uselessly if there are no changes in the website itself. There are already integration or E2E tests testing 'odo deploy' on different projects.
…s of the odo team or certain robot accounts we rely on
🔨 Deploy Preview deleted from internal cluster!
|
Kudos, SonarCloud Quality Gate passed! |
Details
Unrelated /override OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests |
@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Details
Unrelated - issue with mounting volumes (#6894) /override OpenShift-Integration-tests/OpenShift-Integration-tests |
@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Details
Unrelated failures - reported in #6876 /override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests |
@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/area testing
What does this PR do / why we need it:
This improves the website PR preview workflow introduced in #6871 by:
docs/website/
folder. Initially, I wanted to take this as a way to testodo deploy
against any PR changing the source code and/or the website, but this might create useless deployments. We should already have other E2E tests runningodo deploy
.redhat-developer/odo
repo would not require human approval to trigger this workflow.Which issue(s) this PR fixes:
—
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: