Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix login failure on interop tests with error: x509 #6288

Merged

Conversation

anandrkskd
Copy link
Contributor

Signed-off-by: anandrkskd [email protected]

What type of PR is this:

/kind bug
/kind tests

What does this PR do / why we need it:
This PR fixes failing interop tests on 4.11/4.12.
Tests are failing as it doesn't contain changes from PR which was implemented on v2 branch.

Which issue(s) this PR fixes:

Fixes #NA

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Nov 7, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 49de02f
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/636b6c62376dec00086f157d
😎 Deploy Preview https://deploy-preview-6288--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. kind/tests labels Nov 7, 2022
@openshift-ci openshift-ci bot requested review from dharmit and rnapoles-rh November 7, 2022 04:43
@odo-robot
Copy link

odo-robot bot commented Nov 7, 2022

NoCluster Tests on commit bfb526b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 7, 2022

Unit Tests on commit bfb526b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 7, 2022

Validate Tests on commit bfb526b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 7, 2022

Windows Tests (OCP) on commit bfb526b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 7, 2022

Kubernetes Tests on commit bfb526b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 7, 2022

OpenShift Tests on commit bfb526b finished with errors.
View logs: TXT HTML

@anandrkskd
Copy link
Contributor Author

/retest

1 similar comment
@anandrkskd
Copy link
Contributor Author

/retest

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 8, 2022
@rm3l
Copy link
Member

rm3l commented Nov 8, 2022

/test v4.11-integration-e2e

@feloy
Copy link
Contributor

feloy commented Nov 8, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 8, 2022
@rm3l
Copy link
Member

rm3l commented Nov 8, 2022

@anandrkskd Can you rebase this branch onto main? Tests on Prow should be fixed with #6291

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 9, 2022
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks.

Can you rebase this branch onto main? Tests should be fixed with #6291

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 9, 2022
@anandrkskd anandrkskd force-pushed the update-PR-job-script branch from dcc15b5 to 49de02f Compare November 9, 2022 09:01
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 9, 2022

New changes are detected. LGTM label has been removed.

@rm3l rm3l added this to the v3.3.0 🚀 milestone Nov 9, 2022
@rm3l rm3l added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 9, 2022
@rm3l
Copy link
Member

rm3l commented Nov 9, 2022

Tests passing on Prow, but not on IBM Cloud, with similar errors (net/http: TLS handshake timeout):

[odo]  •  Downloading starter project "nodejs-starter"  ...
    [odo]  ✗  Downloading starter project "nodejs-starter" [10s]
    [odo]  ✗  unable to download starter project "nodejs-starter": Get "[https://github.com/odo-devfiles/nodejs-ex.git/info/refs?service=git-upload-pack":](https://github.com/odo-devfiles/nodejs-ex.git/info/refs?service=git-upload-pack%22:) net/http: TLS handshake timeout
    [odo] the command failed, the devfile has been removed from current directory
    Deleting project: cmd-add-binding-test253onx
    Running kubectl with args [kubectl delete namespaces cmd-add-binding-test253onx --wait=false] and odo env: []
    [kubectl] namespace "cmd-add-binding-test253onx" deleted
    Setting current dir to: /go/odo_1/tests/integration
    Deleting dir: /tmp/1748382796
    Deleting dir: /tmp/2598565857
  << End Captured GinkgoWriter Output

  No future change is possible.  Bailing out early - after 14.022s.
  Running odo with args [odo init --name mynode --devfile-path /go/odo_1/tests/examples/source/devfiles/nodejs/devfile.yaml --starter nodejs-starter] and odo env: []
  Expected
      <int>: 1
  to match exit code:
      <int>: 0
  In [BeforeEach] at: /go/odo_1/tests/helper/helper_cmd_wrapper.go:101

Let's try again..

@rm3l rm3l closed this Nov 9, 2022
@rm3l rm3l reopened this Nov 9, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l
Copy link
Member

rm3l commented Nov 9, 2022

/override OpenShift-Integration-tests/OpenShift-Integration-tests

E2E Tests failing on net/http: TLS handshake timeout when fetching starter project from GitHub. Previous run passed.

@openshift-ci
Copy link

openshift-ci bot commented Nov 9, 2022

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

E2E Tests failing on net/http: TLS handshake timeout when fetching starter project from GitHub. Previous run passed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit f96c35a into redhat-developer:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants