Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests fail due to change in "nodeshift-starters/devfile-sample" repository #6291

Closed
dharmit opened this issue Nov 8, 2022 · 0 comments · Fixed by #6292
Closed
Assignees
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering
Milestone

Comments

@dharmit
Copy link
Member

dharmit commented Nov 8, 2022

A few hours ago, nodeshift-starters/devfile-sample#19 was merged into the nodeshift-starters/devfile-sample repo which causes the integration tests to fail with below:

Expected
      <string>: commands:
      - apply:
          component: image-build
        id: build-image
      - apply:
          component: kubernetes-deploy
        id: deployk8s
      - composite:
          commands:
          - build-image
          - deployk8s
          group:
            isDefault: true
            kind: deploy
        id: deploy
      components:
      - image:
          dockerfile:
            buildContext: .
            rootRequired: false
            uri: Dockerfile
          imageName: nodejs-image:latest
        name: image-build
      - attributes:
          deployment/container-port: 3001
          deployment/cpuLimit: 100m
          deployment/cpuRequest: 10m
          deployment/memoryLimit: 100Mi
          deployment/memoryRequest: 50Mi
          deployment/replicas: 1
        kubernetes:
          endpoints:
          - name: http-3001
            path: /
            targetPort: 3001
          uri: deploy.yaml
        name: kubernetes-deploy
      metadata:
        attributes:
          alpha.dockerimage-port: 3001
        description: Stack with Node.js 16
        displayName: Node.js Runtime
        language: nodejs
        name: aname
        projectType: nodejs
        provider: Red Hat
        supportUrl: https://github.com/devfile-samples/devfile-support#support-information
        tags:
        - NodeJS
        - Express
        - ubi8
        version: 2.1.0
      parent:
        id: nodejs
        registryUrl: https://registry.devfile.io/
      schemaVersion: 2.2.0
      
  to contain substring
      <string>: outerloop-deploy

Link to one of the failing tests.

/area testing

@openshift-ci openshift-ci bot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Nov 8, 2022
@rm3l rm3l added this to odo Project Nov 8, 2022
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Nov 8, 2022
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Nov 8, 2022
@rm3l rm3l added this to the v3.3.0 🚀 milestone Nov 8, 2022
@openshift-merge-robot openshift-merge-robot moved this to Done ✅ in odo Project Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants