Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix login failure error: x509 #6121

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

anandrkskd
Copy link
Contributor

Signed-off-by: anandrkskd [email protected]

What type of PR is this:

/kind tests

What does this PR do / why we need it:
This PR fixes failing interop tests on 4.11/4.12

Which issue(s) this PR fixes:

Fixes #

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anandrkskd
Copy link
Contributor Author

@feloy can you merge this one? We need to merge this one, in order to test if this helps in fixing the error we got during interop testing.

@feloy
Copy link
Contributor

feloy commented Sep 14, 2022

@anandrkskd What is the related issue for doing this?

@anandrkskd
Copy link
Contributor Author

This PR is realated to #6075

@feloy
Copy link
Contributor

feloy commented Sep 14, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 14, 2022
@feloy
Copy link
Contributor

feloy commented Sep 14, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 14, 2022
@feloy feloy removed the request for review from mohammedzee1000 September 14, 2022 17:07
@feloy
Copy link
Contributor

feloy commented Sep 14, 2022

/override SonarCloud Code Analysis

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2022

@feloy: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Analysis
  • Code
  • SonarCloud

Only the following failed contexts/checkruns were expected:

  • SonarCloud Code Analysis
  • ci/prow/images
  • ci/prow/integration-e2e
  • pull-ci-redhat-developer-odo-v2-images
  • pull-ci-redhat-developer-odo-v2-integration-e2e
  • tide

In response to this:

/override SonarCloud Code Analysis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anandrkskd anandrkskd merged commit 2b49f83 into redhat-developer:v2 Sep 15, 2022
@anandrkskd anandrkskd deleted the v2-interop-failure branch October 13, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants