Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Glossary #46

Merged
merged 1 commit into from
Feb 9, 2019
Merged

Add Glossary #46

merged 1 commit into from
Feb 9, 2019

Conversation

gmsecrieru
Copy link
Member

closes #14

This was referenced Feb 9, 2019
Closed
Closed
tibuurcio
tibuurcio approved these changes Feb 9, 2019
View reviewed changes
Copy link
Collaborator

@tibuurcio tibuurcio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@halian-vilela
Copy link
Collaborator

I've added the my correction in #34. Just not to have conflicting glossary proposals, which format should we use?

@cezaraugusto
Copy link
Member

@halian-vilela I think this way is better for reading. I'm going to merge this one could please you do a follow-up PR adding content you did and not included in this file?

cezaraugusto
cezaraugusto approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 73e9a5b into master Feb 9, 2019
@halian-vilela
Copy link
Collaborator

@halian-vilela I think this way is better for reading. I'm going to merge this one could please you do a follow-up PR adding content you did and not included in this file?

Sure, done in #50

I'll try to keep the other format in my repo, just in case...

@cezaraugusto cezaraugusto added 📖 glossary | style-guide Definitions about terms in glossary and style-guide and removed 💪 long page - more than 100 lines Long page labels Feb 14, 2019
@jcserracampos jcserracampos deleted the feature-glossary branch July 26, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibuurcio tibuurcio tibuurcio approved these changes

@cezaraugusto cezaraugusto cezaraugusto approved these changes

Assignees
No one assigned
Labels
📖 glossary | style-guide Definitions about terms in glossary and style-guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: start versioning Glossary
4 participants
@gmsecrieru @halian-vilela @cezaraugusto @tibuurcio