[macos] run macos cpp tests on apple silicon #56222
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Buildkite CI configuration to run the C++ and Java tests on a macos-arm64 instance. While this is a good step towards supporting Apple Silicon, the associated test script ci/ray_ci/macos/macos_ci.sh contains a hardcoded JAVA_HOME path. This path may not be valid on the new arm64 architecture, which could lead to build failures. I've added a comment highlighting this risk and suggesting a more robust way to set the Java home directory.
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
github-actions
bot
added
the
stale
aslonnie
removed
the
stale
aslonnie
force-pushed
the
lonnie-250903-macosarm64
branch
from
8efcac3 to
57a6f00
Compare
aslonnie
requested review from
a team,
SongGuyang,
kfstorm and
raulchen
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
aslonnie
force-pushed
the
lonnie-250903-macosarm64
branch
2 times, most recently
from
bf83e37 to
de604c2
Compare
|
new attempt: https://buildkite.com/ray-project/postmerge-macos/builds/8388#_ just disable java.. it does not work anyways. and no one should be using new ray version with intel silicon macos any more. |
aslonnie
force-pushed
the
lonnie-250903-macosarm64
branch
3 times, most recently
from
ac421ec to
e8a826a
Compare
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
github-actions
bot
added
the
stale
aslonnie
changed the title
aslonnie
removed
the
stale
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
aslonnie
force-pushed
the
lonnie-250903-macosarm64
branch
from
27fd11b to
b67b0cf
Compare
|
ready for review now. |
|
after this is merged, I can kill the intel silicon macos CI machines. |
- disables java tests - skipping cpp tests that are not passing yet and we already stopped releasing macos wheels for Intel silicon, the tests that are disabled or skipped were never passing on apple silicon, so nothing is regressed. Signed-off-by: Lonnie Liu <[email protected]>
aslonnie
force-pushed
the
lonnie-250903-macosarm64
branch
from
b67b0cf to
e2f67a7
Compare
.bazelrc
Outdated
| # It picks up the system headers when someone has protobuf installed via Homebrew. | ||
| # Work around for https://github.com/bazelbuild/bazel/issues/8053 | ||
| build:macos --sandbox_block_path=/usr/local/ | ||
| build:macos --copt="-Wno-deprecated-declarations" |
There was a problem hiding this comment.
without this, compiler will error even on deprecated protobuf fields.
yes, java was working on intel macs. our java is using jdk 8, which is super old and jdk8 does not have apple silicon support. there is an attempt to upgrade to jdk 17: but jdk 17 does not work out of the box. |
- disables java tests; ray java not supported on apple silicon yet. - skipping cpp tests that are not passing yet we already stopped releasing macos wheels for Intel silicon, the tests that are disabled or skipped were never passing on apple silicon, so nothing is regressed. Signed-off-by: Lonnie Liu <[email protected]>
- disables java tests; ray java not supported on apple silicon yet. - skipping cpp tests that are not passing yet we already stopped releasing macos wheels for Intel silicon, the tests that are disabled or skipped were never passing on apple silicon, so nothing is regressed. Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: xgui <[email protected]>
- disables java tests; ray java not supported on apple silicon yet. - skipping cpp tests that are not passing yet we already stopped releasing macos wheels for Intel silicon, the tests that are disabled or skipped were never passing on apple silicon, so nothing is regressed. Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: elliot-barn <[email protected]>
- disables java tests; ray java not supported on apple silicon yet. - skipping cpp tests that are not passing yet we already stopped releasing macos wheels for Intel silicon, the tests that are disabled or skipped were never passing on apple silicon, so nothing is regressed. Signed-off-by: Lonnie Liu <[email protected]>
- disables java tests; ray java not supported on apple silicon yet. - skipping cpp tests that are not passing yet we already stopped releasing macos wheels for Intel silicon, the tests that are disabled or skipped were never passing on apple silicon, so nothing is regressed. Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
we already stopped releasing macos wheels for Intel silicon, the tests that are disabled or skipped were never passing on apple silicon, so nothing is regressed.