Skip to content

Conversation

@czgdp1807
Copy link
Contributor

Why are these changes needed?

Except ci/build/build-manylinux-forge.sh (seems like yum has JDK 11 at max), I am able to switch to JDK 17.

cc: @aslonnie

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Gagandeep Singh <[email protected]>
@czgdp1807 czgdp1807 requested a review from a team as a code owner September 5, 2025 09:39
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the JDK version from 8 to 17 across various CI/CD scripts and Dockerfiles. The changes are mostly correct, but I've found a couple of issues. There is a critical issue in ci/env/install-hdfs.sh where JAVA_HOME is not updated to the new JDK path; I've added a specific comment for that. Additionally, java/build-jar-multiplatform.sh contains a function check_java_version which still enforces JDK 8. This will likely cause build failures and should be updated to check for JDK 17. Finally, please ensure that the pom.xml files have been updated to target Java 17 (e.g., by setting <maven.compiler.source>17</maven.compiler.source> and <maven.compiler.target>17</maven.compiler.target>), as these files were not part of the pull request and might need changes.

@ray-gardener ray-gardener bot added core Issues that should be addressed in Ray Core devprod community-contribution Contributed by the community labels Sep 5, 2025
@aslonnie
Copy link
Collaborator

see #56620 for help on java test reproduce

Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems that tests are failing. do we have an idea on why it is failing?

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Oct 2, 2025
@github-actions
Copy link

This pull request has been automatically closed because there has been no more activity in the 14 days
since being marked stale.

Please feel free to reopen or open a new pull request if you'd still like this to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for your contribution!

@github-actions github-actions bot closed this Oct 16, 2025
@aslonnie aslonnie reopened this Oct 16, 2025
@aslonnie aslonnie self-requested a review October 16, 2025 14:04
@github-actions github-actions bot added unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it. and removed stale The issue is stale. It will be closed within 7 days unless there are further conversation labels Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community core Issues that should be addressed in Ray Core devprod unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants