[macos] run macos cpp tests on apple silicon (#56222)

- disables java tests; ray java not supported on apple silicon yet.    
- skipping cpp tests that are not passing yet

we already stopped releasing macos wheels for Intel silicon, the tests
that are disabled or skipped were never passing on apple silicon, so
nothing is regressed.

Signed-off-by: Lonnie Liu <[email protected]>
Signed-off-by: elliot-barn <[email protected]>

Author: aslonnie

.bazelrc

@@ -237,5 +237,6 @@ try-import %workspace%/.user.bazelrc
 # It picks up the system headers when someone has protobuf installed via Homebrew.
 # Work around for https://github.com/bazelbuild/bazel/issues/8053
 build:macos --sandbox_block_path=/usr/local/
+build:macos --copt="-Wno-error=deprecated-declarations"
 # This option controls whether javac checks for missing direct dependencies.
 build --experimental_strict_java_deps=off

.buildkite/macos/macos.rayci.yml

@@ -88,9 +88,9 @@ steps:
       - macos_wheels
       - oss
     job_env: MACOS
-    instance_type: macos
+    instance_type: macos-arm64
     commands:
-      - RAY_INSTALL_JAVA=1 ./ci/ray_ci/macos/macos_ci.sh run_ray_cpp_and_java
+      - RAY_INSTALL_JAVA=0 ./ci/ray_ci/macos/macos_ci.sh run_ray_cpp
 
   - label: ":ray: core: :mac: flaky tests"
     key: macos_flaky_tests

ci/ci.sh

@@ -117,6 +117,11 @@ compile_pip_dependencies() {
 }
 
 test_cpp() {
+  if [[ "${OSTYPE}" == darwin* ]]; then
+    echo "use macos_ci.sh to run cpp tests"
+    exit 1
+  fi
+
   # C++ worker example need _GLIBCXX_USE_CXX11_ABI flag, but if we put the flag into .bazelrc, the linux ci can't pass.
   # So only set the flag in c++ worker example. More details: https://github.com/ray-project/ray/pull/18273
   echo build --cxxopt="-D_GLIBCXX_USE_CXX11_ABI=0" >> ~/.bazelrc
@@ -126,16 +131,17 @@ test_cpp() {
   BAZEL_EXPORT_OPTIONS=($(./ci/run/bazel_export_options))
   bazel test --config=ci "${BAZEL_EXPORT_OPTIONS[@]}" --test_strategy=exclusive //cpp:all --build_tests_only
   # run cluster mode test with external cluster
-  bazel test //cpp:cluster_mode_test --test_arg=--external_cluster=true \
+  bazel test --config=ci //cpp:cluster_mode_test --test_arg=--external_cluster=true \
     --test_arg=--ray_redis_password="1234" --test_arg=--ray_redis_username="default"
-  bazel test --test_output=all //cpp:test_python_call_cpp
+  bazel test --config=ci --test_output=all //cpp:test_python_call_cpp
 
   # run the cpp example, currently does not work on mac
-  if [[ "${OSTYPE}" != darwin* ]]; then
-    rm -rf ray-template
-    ray cpp --generate-bazel-project-template-to ray-template
-    pushd ray-template && bash run.sh
-  fi
+  rm -rf ray-template
+  ray cpp --generate-bazel-project-template-to ray-template
+  (
+    cd ray-template
+    bash run.sh
+  )
 }
 
 test_macos_wheels() {

ci/ray_ci/macos/macos_ci.sh

@@ -85,13 +85,20 @@ run_core_dashboard_test() {
     //:all python/ray/dashboard/... -python/ray/serve/... -rllib/...) || exit 42
 }
 
-run_ray_cpp_and_java() {
-  # clang-format is needed by java/test.sh
-  # 42 is the universal rayci exit code for test failures
-  pip install clang-format==12.0.1
-  export JAVA_HOME=/Library/Java/JavaVirtualMachines/temurin-8.jdk/Contents/Home
-  ./java/test.sh || exit 42
-  ./ci/ci.sh test_cpp || exit 42
+run_ray_cpp() {
+  echo "--- Generate ray cpp package"
+  bazel run --config=ci //cpp:gen_ray_cpp_pkg
+
+  echo "--- Test //cpp:all"
+  bazel test --config=ci --test_strategy=exclusive --build_tests_only \
+    --test_tag_filters=-no_macos //cpp:all
+
+  echo "--- Test //cpp:cluster_mode_test"
+  bazel test --config=ci //cpp:cluster_mode_test --test_arg=--external_cluster=true \
+    --test_arg=--ray_redis_password="1234" --test_arg=--ray_redis_username="default"
+
+  echo "--- Test //cpp:test_python_call_cpp"
+  bazel test --config=ci --test_output=all //cpp:test_python_call_cpp
 }
 
 bisect() {

cpp/BUILD.bazel

@@ -273,7 +273,10 @@ cc_test(
         "//java:libio_ray_ray_test.jar",
     ],
     linkstatic = True,
-    tags = ["team:core"],
+    tags = [
+        "no_macos",
+        "team:core",
+    ],
     deps = [
         "ray_api_lib",
         "@com_google_googletest//:gtest_main",
@@ -464,5 +467,9 @@ py_test(
         "SIMPLE_DRIVER_SO_PATH": "$(location simple_job.so)",
         "SIMPLE_DRIVER_MAIN_PATH": "$(location simple_job)",
     },
-    tags = ["team:core"],
+    tags = [
+        # TODO(ray-core): fix this test on apple silicon macos.
+        "no_macos",
+        "team:core",
+    ],
 )