Conversation
simoneves
requested review from
Avinash-Raj,
mattgara,
misiugodfrey,
patdevinwilson,
paul-aiyedun and
tmostak
simoneves
commented
Oct 27, 2025
| # optimizer.joins-not-null-inference-strategy=USE_FUNCTION_METADATA | ||
| # optimizer.default-filter-factor-enabled=true | ||
| COORD_CONFIG="generated/etc_coordinator/config_native.properties" | ||
| sed -i 's/\#optimizer/optimizer/g' ${COORD_CONFIG} |
Contributor
Author
There was a problem hiding this comment.
This is simple for now, but me fear is that the requirement for modification may grow to be unmanageable, and forking may turn out to be a better solution.
Then again, we can switch to forking when we have to.
simoneves
added
hotfix
paul-aiyedun
approved these changes
Oct 29, 2025
simoneves
deleted the
seves/reinstate_optimizer_config_for_gpu_only_alt
branch
This was referenced Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation to #103 which avoids forking the template files.
This is much simpler than the above FOR NOW... but are we painting ourselves into a corner as CPU/GPU divergence increases?