Presto: Reinstate a query optimizer flag for GPU only (ALSO SEE PR #111)#103
Closed
Presto: Reinstate a query optimizer flag for GPU only (ALSO SEE PR #111)#103
Conversation
simoneves
requested review from
Avinash-Raj,
mattgara,
misiugodfrey,
patdevinwilson,
paul-aiyedun and
tmostak
simoneves
added
hotfix
simoneves
force-pushed
the
seves/reinstate_optimizer_config_for_gpu_only
branch
from
7488fed to
30c036c
Compare
simoneves
commented
Oct 27, 2025
|
|
||
| # Optimizer flags | ||
| # Use a default filter factor to estimate the selectivity of filters in queries? Good for GPU. Bad for CPU. | ||
| optimizer.default-filter-factor-enabled=false |
Contributor
Author
There was a problem hiding this comment.
This file is identical to the GPU version other than this one flag
simoneves
changed the title
Contributor
Author
|
Closing as we went with #111 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TPCH Q21 on GPU requires this flag to be on for best performance, but CPU requires it to be off.
As there is no way to pass CPU-or-GPU state through
pbench genconfig, this required diverging the CPU and GPU Coordinator config files, which are otherwise identical.