Skip to content

Presto: Reinstate a query optimizer flag for GPU only (ALTERNATIVE IMPLEMENTATION) #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simoneves merged 2 commits into from
Oct 29, 2025
Merged

Presto: Reinstate a query optimizer flag for GPU only (ALTERNATIVE IMPLEMENTATION) #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56dff98
Reinstate optimizer configs, but commented-out by default
simoneves Oct 27, 2025
7c654ee
Implement post-modification
simoneves Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions presto/docker/config/template/etc_coordinator/config_native.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ node-scheduler.max-pending-splits-per-task=2000
node-scheduler.max-splits-per-node=2000

# Optimizer flags
# New option in 0.282 to control inference of NOT NULL columns in joins (undocumented).
#optimizer.joins-not-null-inference-strategy=USE_FUNCTION_METADATA
# Use a default filter factor to estimate the selectivity of filters in queries.
#optimizer.default-filter-factor-enabled=true
# Use known constraints to simplify plan and filters.
optimizer.exploit-constraints=true
# Rewrite large IN lists as joins for performance in some cases.
Expand Down
9 changes: 9 additions & 0 deletions presto/scripts/generate_presto_config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,13 @@ if ../../pbench/pbench genconfig -p params.json -t template generated 2>&1 | gre
echo_error "ERROR in pbench genconfig. Configs were not generated successfully"
fi

# now perform other variant-specific modifications to the generated configs
if [[ "${VARIANT_TYPE}" == "gpu" ]]; then
# for GPU variant, uncomment these optimizer settings
# optimizer.joins-not-null-inference-strategy=USE_FUNCTION_METADATA
# optimizer.default-filter-factor-enabled=true
COORD_CONFIG="generated/etc_coordinator/config_native.properties"
sed -i 's/\#optimizer/optimizer/g' ${COORD_CONFIG}

@simoneves simoneves Oct 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simple for now, but me fear is that the requirement for modification may grow to be unmanageable, and forking may turn out to be a better solution.

Then again, we can switch to forking when we have to.

fi

echo_success "Configs were generated successfully"