Add 'build_workflow_name' input, to allow overriding where scripts look for artifacts - #331
Merged
Merged
Conversation
ajschmidt8
approved these changes
Apr 29, 2025
Member
|
I've added context for why we're doing this in the description, and re-targeted this at |
jameslamb
added a commit
to rapidsai/shared-actions
that referenced
this pull request
May 23, 2025
Adding a new optional input to specify a custom workflow (only if required, defaults to build.yaml) to download artifacts from, primarily for nightly tests (see rapidsai/gha-tools#162 (comment)) Complementary changes in `shared-workflows`: rapidsai/shared-workflows#331 --------- Co-authored-by: James Lamb <jaylamb20@gmail.com>
3 tasks
Member
|
I just pushed some changes in c34104a
I've also changed the PR title to more accurately reflect the goal here. |
ajschmidt8
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uniquely identifying an artifact from the GitHub Actions artifact store requires identifying the workflow run that produced it.
In PR CI, this is trivial because the uploading-artifacts and downloading-artifacts jobs are all running as part of the same workflow.
In other setups though, that isn't true. For example, RAPIDS uses 2 separate nightly workloads:
build.yaml= build packages and publish the package artifactstest.yaml= pull those artifacts and run tests with themFor this case, in the relevant
gha-toolsscripts we default to assuming thatbranchornightlyruns want to pull artifacts from runs of a workflow literally calledbuild.yaml:ref: https://github.com/rapidsai/gha-tools/blob/570fc211e6bf1bfb91098aa1bc4823ef7bb71fc2/tools/rapids-github-run-id#L66
There might be cases in the future where that assumption doesn't hold, and people want to pull artifacts in one workflow run from some other workflow which is NOT called
build.yaml.This PR + rapidsai/shared-actions#52 add support for specifying the name of that "some other workflow" as an input, overriding the
build.yamldefault.For more context, see rapidsai/gha-tools#162 (comment)
How I tested this
Tested with an
rmmPR: rapidsai/rmm#1909RAPIDS_BUILD_WORKFLOW_NAMEvariable: WIP: [DO NOT MERGE] test changes to GitHub Actions configs and scripts rmm#1909 (comment)