Skip to content

WIP: [DO NOT MERGE] test changes to GitHub Actions configs and scripts - #1909

Closed
jameslamb wants to merge 13 commits into
rapidsai:branch-25.08from
jameslamb:test-gha-tools-changes
Closed

WIP: [DO NOT MERGE] test changes to GitHub Actions configs and scripts#1909
jameslamb wants to merge 13 commits into
rapidsai:branch-25.08from
jameslamb:test-gha-tools-changes

Conversation

@jameslamb

Copy link
Copy Markdown
Member

Description

Opening this to test ongoing changes to our GitHub Actions infrastructure, described in https://github.com/rapidsai/build-infra/issues/237 (private issue, sorry 😬).

this should never be merged

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added the DO NOT MERGE Hold off on merging; see PR for details label May 8, 2025
@copy-pr-bot

copy-pr-bot Bot commented May 8, 2025

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb

Copy link
Copy Markdown
Member Author

/ok to test 4197d8b

@jameslamb

Copy link
Copy Markdown
Member Author

/ok to test 109cdd2

@jameslamb

Copy link
Copy Markdown
Member Author

/ok to test 9967cda

@jameslamb

Copy link
Copy Markdown
Member Author

/ok to test

@jameslamb

Copy link
Copy Markdown
Member Author

Shifting this testing over to branch-25.08, now that rmm is about to enter code freeze. But everything being tested here is on both branch-25.06 and branch-25.08, so this should still hopefully give us decent confidence that things are working for branch-25.06.

@jameslamb
jameslamb changed the base branch from branch-25.06 to branch-25.08 May 22, 2025 19:02
@jameslamb

Copy link
Copy Markdown
Member Author

/ok to test

@github-actions github-actions Bot removed the ci label May 28, 2025
@jameslamb

Copy link
Copy Markdown
Member Author

Repurposing this PR again, to test rapidsai/shared-workflows#331

@jameslamb

Copy link
Copy Markdown
Member Author

/ok to test

@jameslamb

Copy link
Copy Markdown
Member Author

/ok to test

@jameslamb

jameslamb commented May 28, 2025

Copy link
Copy Markdown
Member Author

This looked like it worked, for the case where workflows don't provide a new value for build_workflow_name.

Seeing what I'd expect in the "Standardize repository information" stage for test workflows:

Run rapidsai/shared-actions/rapids-github-info@main
Run echo "RAPIDS_REPOSITORY=rapidsai/rmm" | tee --append "${GITHUB_ENV}" "${GITHUB_OUTPUT}"
RAPIDS_REPOSITORY=rapidsai/rmm
RAPIDS_SHA=c57210fe60bf98c15aefc11135380fad88184dd1
RAPIDS_REF_NAME=pull-request/1909
RAPIDS_NIGHTLY_DATE=

Notice that RAPIDS_BUILD_WORKFLOW_NAME is not set, as expected.

(build link)

@jameslamb

Copy link
Copy Markdown
Member Author

/ok to test

@jameslamb

Copy link
Copy Markdown
Member Author

It looks like passing the build_workflow_name worked!

Commit: aea0ddb

Seeing what I'd expect in the "Standardize repository information" stage for test workflows:

Run rapidsai/shared-actions/rapids-github-info@main
Run echo "RAPIDS_REPOSITORY=rapidsai/rmm" | tee --append "${GITHUB_ENV}" "${GITHUB_OUTPUT}"
RAPIDS_REPOSITORY=rapidsai/rmm
RAPIDS_SHA=aea0ddb3f13f07a7364cf33e4e13530f359a383d
RAPIDS_REF_NAME=pull-request/1909
RAPIDS_NIGHTLY_DATE=
RAPIDS_BUILD_WORKFLOW_NAME=sparkly-unicorn.yaml

(build link)

And downloading artifacts failed, but with an error that shows that that value was used:

HTTP 404: workflow sparkly-unicorn.yaml not found on the default branch (https://api.github.com/repos/rapidsai/rmm/actions/workflows/sparkly-unicorn.yaml)

This is enough to convince me that the configuration made it all the way down to the place that needed it.

@jameslamb

Copy link
Copy Markdown
Member Author

This testing is complete, this can be closed.

@jameslamb jameslamb closed this May 30, 2025
@jameslamb
jameslamb deleted the test-gha-tools-changes branch May 30, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Hold off on merging; see PR for details

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant