Skip to content

Add rapids-retry to gh commands - #162

Merged
ajschmidt8 merged 1 commit into
rapidsai:mainfrom
jayavenkatesh19:retry-with-run-env
Apr 25, 2025
Merged

Add rapids-retry to gh commands#162
ajschmidt8 merged 1 commit into
rapidsai:mainfrom
jayavenkatesh19:retry-with-run-env

Conversation

@jayavenkatesh19

@jayavenkatesh19 jayavenkatesh19 commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

This PR addresses nightly CI test fails due to wrong Github actions run ID being picked up, and also add the rapids-retry function to any gh cli calls to avoid failures due to network inconsistencies.

@jayavenkatesh19 jayavenkatesh19 self-assigned this Apr 25, 2025
@jayavenkatesh19
jayavenkatesh19 requested a review from a team as a code owner April 25, 2025 21:12
@ajschmidt8

ajschmidt8 commented Apr 25, 2025

Copy link
Copy Markdown
Member

approving and merging but I've asked @VenkateshJaya to document the use of the new RAPIDS_BUILD_WORKFLOW_NAME variable in the body of this PR for posterity.

@ajschmidt8
ajschmidt8 merged commit 64722ba into rapidsai:main Apr 25, 2025
@jayavenkatesh19

jayavenkatesh19 commented Apr 25, 2025

Copy link
Copy Markdown
Contributor Author

Due to the switch in storing build artifacts on Github Artifact Store rather than S3 (downloads.rapids.ai), there is a change involved in the way artifacts in nightly builds are handled.

Previously on S3, when the build.yaml workflow is triggered by the nightly trigger, all the build artifacts were uploaded to a S3 path like /repo/nightly/sha and the test.yaml workflow run was able to download these artifacts as they have the same commit and use them for build tests.

However, on Github, artifacts are contained within a workflow run and due to the fact that build and test are runs of two different workflows, this is causing the test workflow runs to fail due to artifacts not being present within the run.

To handle this, when downloading artifacts on nightly workflows, we will be querying all the runs associated with that specific commit, and using artifacts from the build.yaml workflow of that specific commit.

There is a possibility for edge cases to exist in this scenario, like when the artifacts to be tested are built on a different workflow other than build.yaml. For such scenarios, the RAPIDS_BUILD_WORKFLOW_NAME env-var is introduced which can be used to specify the name of the workflow file (only works if a run is made on the specified commit) from which artifacts are to be downloaded.

I will be opening a PR on shared-workflows to add this optional input for these edge cases and linking it here.

See rapidsai/shared-actions#52 and rapidsai/shared-workflows#331

jameslamb added a commit to rapidsai/shared-actions that referenced this pull request May 23, 2025
Adding a new optional input to specify a custom workflow (only if
required, defaults to build.yaml) to download artifacts from, primarily
for nightly tests (see
rapidsai/gha-tools#162 (comment))

Complementary changes in `shared-workflows`:
rapidsai/shared-workflows#331

---------

Co-authored-by: James Lamb <jaylamb20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants