Skip to content

Use configFile option, support an additional repo deploy key#175

Merged
vyasr merged 21 commits intobranch-24.04from
fix/devcontainer-json-location
Mar 8, 2024
Merged

Use configFile option, support an additional repo deploy key#175
vyasr merged 21 commits intobranch-24.04from
fix/devcontainer-json-location

Conversation

@trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Feb 6, 2024

  • Make build-in-devcontainer action use the new configFile option
  • Support an additional extra-repo-deploy-key in build-in-devcontainer action

Both of these changes are necessary to build all the RAPIDS projects in rapidsai/devcontainers CI jobs.

@trxcllnt
Copy link
Contributor Author

trxcllnt commented Feb 7, 2024

The devcontainers builds in rapidsai/cuml#5760 passes, so I think this change is safe.

@trxcllnt trxcllnt requested review from bdice and vyasr February 7, 2024 06:44
@trxcllnt trxcllnt requested a review from bdice February 9, 2024 17:59
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but looks good.

@trxcllnt
Copy link
Contributor Author

trxcllnt commented Mar 8, 2024

@bdice @vyasr All the PRs that depend on this branch have been merged, so I'm going to merge this into branch-24.04.

@trxcllnt
Copy link
Contributor Author

trxcllnt commented Mar 8, 2024

/merge

@vyasr vyasr merged commit 1f460ea into branch-24.04 Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants