Update devcontainers to CUDA Toolkit 12.2#15099
Merged
rapids-bot[bot] merged 13 commits intorapidsai:branch-24.04from Mar 4, 2024
Merged
Update devcontainers to CUDA Toolkit 12.2#15099rapids-bot[bot] merged 13 commits intorapidsai:branch-24.04from
rapids-bot[bot] merged 13 commits intorapidsai:branch-24.04from
Conversation
trxcllnt
added
3 - Ready for Review
bdice
reviewed
Feb 21, 2024
| devcontainer: | ||
| secrets: inherit | ||
| uses: rapidsai/shared-action-workflows/.github/workflows/build-in-devcontainer.yaml@branch-24.04 | ||
| uses: rapidsai/shared-workflows/.github/workflows/build-in-devcontainer.yaml@fix/devcontainer-json-location |
Contributor
There was a problem hiding this comment.
Can we merge that shared-workflows PR into branch-24.04 before merging this PR? Or is there a dependency between the merge order?
Contributor
Author
There was a problem hiding this comment.
We need to merge this before the shared-workflows PR.
Contributor
Author
There was a problem hiding this comment.
The build-in-devcontainer.yaml was hard-coded to CUDA 12.0 and the new workflow makes that configurable.
AyodeAwe
approved these changes
Feb 21, 2024
Contributor
|
/merge |
bdice
approved these changes
Feb 26, 2024
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.