Skip to content

fix(ci): fix configuration for breaking change notification workflow - #2435

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
jameslamb:fix/breaking-change-alert
Jun 1, 2026
Merged

fix(ci): fix configuration for breaking change notification workflow#2435
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
jameslamb:fix/breaking-change-alert

Conversation

@jameslamb

Copy link
Copy Markdown
Member

Contributes to rapidsai/shared-workflows#560

Fixes misconfigurations in the GitHub Actions workflow that generates Notifications when PRs are labeled breaking.

Any other changes come from making the configuration for this workflow identical across all RAPIDS repos.

@jameslamb jameslamb added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jun 1, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb

Copy link
Copy Markdown
Member Author

/ok to test

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6442618a-6a39-4b28-ac1f-07955dab7f08

📥 Commits

Reviewing files that changed from the base of the PR and between 3a84fbe and 0d94733.

📒 Files selected for processing (1)
  • .github/workflows/trigger-breaking-change-alert.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated workflow configuration for internal CI/CD process to enhance security by refining permission and credential handling for automated notifications.

Walkthrough

This PR hardens the GitHub Actions workflow security posture by replacing inherited secrets and permissions with explicit, minimal grants. The trigger-notifier job now specifies only the contents: read permission needed and explicitly maps the slack-webhook-url secret instead of inheriting all secrets.

Changes

Workflow permissions and secrets configuration

Layer / File(s) Summary
Trigger-notifier job permissions and secrets
.github/workflows/trigger-breaking-change-alert.yaml
The trigger-notifier job permissions change from inherited to explicit contents: read, and secrets handling changes from secrets: inherit to an explicit mapping providing slack-webhook-url from NV_SLACK_BREAKING_CHANGE_NOTIFIER_APP.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • rapidsai/rmm#2373: Also updates the trigger-breaking-change-alert.yaml workflow configuration and the trigger-notifier job's permission and secrets settings.

Suggested reviewers

  • gforsyth
  • bdice
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: fixing the configuration of the breaking change notification workflow in CI.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of the workflow fix and referencing the relevant issue and consistency goals across repositories.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.


Comment @coderabbitai help to get the list of available commands and usage tips.

@jameslamb
jameslamb marked this pull request as ready for review June 1, 2026 16:26
@jameslamb
jameslamb requested a review from a team as a code owner June 1, 2026 16:26
@jameslamb
jameslamb requested a review from KyleFromNVIDIA June 1, 2026 16:26

@jakirkham jakirkham left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James! 🙏

@jameslamb

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 6215ecd into rapidsai:main Jun 1, 2026
87 checks passed
rapids-bot Bot pushed a commit that referenced this pull request Jun 1, 2026
…#2438)

Follow-up to #2435

Adds a default `permissions: {}` block in the trigger-breaking-change-alert GitHub Actions configuration. This change reduces the risk of unnecessary permissions being granted to that workflow, and standardizes with all other RAPIDS repos (rapidsai/shared-workflows#560).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - https://github.com/jakirkham
  - Bradley Dice (https://github.com/bdice)

URL: #2438
This was referenced Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants