Upgrade to nvCOMP 5.0.0.6#800
Merged
rapids-bot[bot] merged 8 commits intorapidsai:branch-25.10from Aug 20, 2025
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
vuule
added
feature request
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 19, 2025
#798 removed usage of nvcomp but left the linkage in place, kvikio extension modules still relied on nvcomp existing even though they didn't actually use any of its functionality. That is now causing problems in #800. Removing the linkage entirely here (while still revendoring manually until we can move the vendoring to cudf) should resolve that. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) URL: #801
Contributor
|
/ok to test |
3 tasks
Contributor
Author
|
Added "do not merge" label so we don't accidentally merge before reverting changes here https://github.com/rapidsai/kvikio/pull/800/files#diff-64b517b8bafdd2024e48760683d9d249c60ce85f52807058570f1123036d0ac9, after the rapids-cmake PR is merged. |
bdice
approved these changes
Aug 19, 2025
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
Approved, but we'll need to revert the rapids-cmake change before merging.
Contributor
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Aug 20, 2025
Issue #19686 Update the nvCOMP version and the JNI code that directly uses nvCOMP. The libcudf code is already compatible with this version. Depends on rapidsai/rapids-cmake#896 and rapidsai/kvikio#800 Authors: - Vukasin Milovanovic (https://github.com/vuule) - Liangcai Li (https://github.com/firestarman) - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) - Muhammad Haseeb (https://github.com/mhaseeb123) - Nghia Truong (https://github.com/ttnghia) - Alessandro Bellina (https://github.com/abellina) URL: #19636
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the nvCOMP dependency to 5.0.0.6.
This library is not used directly, but it's till vendored and used in libcudf wheels. Future changes will completely remove the dependency in kvikIO.
Depends on rapidsai/rapids-cmake#896