Remove remaining nvcomp references#801
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.10from Aug 19, 2025
Merged
Conversation
vyasr
added
bug
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
vyasr
commented
Aug 19, 2025
| rapids_cython_create_modules( | ||
| CXX | ||
| SOURCE_FILES "${cython_modules}" | ||
| LINKED_LIBRARIES kvikio::kvikio nvcomp::nvcomp |
Contributor
Author
There was a problem hiding this comment.
This line is the main change needed to fix the current build failures in #800 (like https://github.com/rapidsai/kvikio/actions/runs/17052265746/job/48342529698?pr=800). The rest of the PR is just good cleanup.
bdice
approved these changes
Aug 19, 2025
Contributor
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 19, 2025
Follow-up to #798 and #801. After libcudf wheels vendor libnvcomp, we can finalize removal of nvcomp from kvikio. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #804
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#798 removed usage of nvcomp but left the linkage in place, kvikio extension modules still relied on nvcomp existing even though they didn't actually use any of its functionality. That is now causing problems in #800. Removing the linkage entirely here (while still revendoring manually until we can move the vendoring to cudf) should resolve that.