Skip to content

Upgrade to nvCOMP 5.0.0.6 #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 8 commits into from
Aug 20, 2025
Merged

Upgrade to nvCOMP 5.0.0.6 #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b45c6a8
switch to nvcomp 5
vuule Aug 18, 2025
1254869
REVERT ME
vuule Aug 18, 2025
acaf77a
Merge branch 'branch-25.10' into fea-nvcomp-5
vuule Aug 18, 2025
2871016
Merge branch 'branch-25.10' into fea-nvcomp-5
bdice Aug 19, 2025
18553be
Merge remote-tracking branch 'upstream/branch-25.10' into fea-nvcomp-5
bdice Aug 19, 2025
2317016
Merge remote-tracking branch 'upstream/branch-25.10' into fea-nvcomp-5
bdice Aug 19, 2025
80d92dc
remove cmake hack
vuule Aug 19, 2025
8220bae
remove extra line
vuule Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/build_wheel_python.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export SKBUILD_CMAKE_ARGS="-DUSE_NVCOMP_RUNTIME_WHEEL=ON"

python -m auditwheel repair \
--exclude libkvikio.so \
--exclude libnvcomp.so.4 \
--exclude libnvcomp.so.5 \
-w "${RAPIDS_WHEEL_BLD_OUTPUT_DIR}" \
${package_dir}/dist/*

Expand Down
2 changes: 1 addition & 1 deletion python/libkvikio/cmake/thirdparty/get_nvcomp.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function(find_and_configure_nvcomp)
include(${rapids-cmake-dir}/cpm/nvcomp.cmake)
set(export_args)
if(KvikIO_EXPORT_NVCOMP)
# We're vendoring nvcomp and we only want `libnvcomp.so.4`
# We're vendoring nvcomp and we only want `libnvcomp.so.5`
set(export_args BUILD_EXPORT_SET nvcomp INSTALL_EXPORT_SET nvcomp)
endif()

Expand Down
2 changes: 1 addition & 1 deletion python/libkvikio/libkvikio/load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def load_library():
# TODO: remove this nvcomp load when `nvcomp` is vendored into cudf instead.
# Currently this load only exists to ensure that libcudf wheels are not broken by
# prematurely removing the load
_load_library("libnvcomp.so.4")
_load_library("libnvcomp.so.5")
return _load_library("libkvikio.so")


Expand Down