Skip to content

Add numba-cuda as runtime dependency #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 3 commits into from
Aug 8, 2025
Merged

Add numba-cuda as runtime dependency #1531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20b8200
Add numba-cuda as runtime dependency
pentschev Aug 8, 2025
c819d17
Use underscores for anchors
pentschev Aug 8, 2025
0ca98c6
Apply suggestions from code review
bdice Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions conda/environments/all_cuda-129_arch-aarch64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ dependencies:
- distributed-ucxx==0.46.*,>=0.0.0a0
- kvikio==25.10.*,>=0.0.0a0
- numactl-devel-cos7-aarch64
- numba-cuda>=0.14.0,<0.15.0a0
- numba>=0.59.1,<0.62.0a0
- numpy>=1.23,<3.0a0
- numpydoc>=1.1.0
Expand Down
1 change: 1 addition & 0 deletions conda/environments/all_cuda-129_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ dependencies:
- distributed-ucxx==0.46.*,>=0.0.0a0
- kvikio==25.10.*,>=0.0.0a0
- numactl-devel-cos7-x86_64
- numba-cuda>=0.14.0,<0.15.0a0
- numba>=0.59.1,<0.62.0a0
- numpy>=1.23,<3.0a0
- numpydoc>=1.1.0
Expand Down
1 change: 1 addition & 0 deletions conda/recipes/dask-cuda/recipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ requirements:
- python
- click >=8.1
- numba >=0.59.1,<0.62.0a0
- numba-cuda >=0.14.0,<0.15.0a0
- numpy >=1.23,<3.0a0
- pandas >=1.3
- pynvml >=12.0.0,<13.0.0a0
Expand Down
12 changes: 12 additions & 0 deletions dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,18 @@ dependencies:
- pynvml>=12.0.0,<13.0.0a0
- rapids-dask-dependency==25.10.*,>=0.0.0a0
- zict>=2.0.0
- output_types: [conda]
packages:
- &numba-cuda-dep numba-cuda>=0.14.0,<0.15.0a0
Copy link
Member

@jameslamb jameslamb Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to rapidsai/ucxx#481 (comment) ... could we make these >=0.14.0,<0.19, to be compatible with both the current state of cudf the state its about to be in when rapidsai/cudf#19604 is merged?

Then tighten this to >=0.18.0,<0.19 once that cudf PR is merged?

Copy link
Member

@jameslamb jameslamb Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok we talked about this in rapidsai/ucxx#481 (comment) and the answer was "no, not right now".

I'm ok with merging this as-is, thanks for the explanation.

Copy link
Member Author

@pentschev pentschev Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xref rapidsai/ucxx#481 (comment):

As a recap, we had to rollback numba-cuda version dependency twice before, immediately this is NOT acceptable IMO. I don’t know if you recall, here's how events unfolded:

  1. First introduced dependency: rapidsai/ucxx@d3aa4a3
  2. Rolled back: rapidsai/ucxx@0f5f99f
  3. And rolled back again: rapidsai/ucxx@41fa142

Since this is a critical issue, that we’ve been seeing segmentation faults in both RAFT and RMM, I think we first need to go the safe route and make sure everything is back to normal, then we can update the pin to a newer version.

Let's play it safe here as well, once we're sure everything is fine with numba-cuda being installed, then we can try a new version and make sure nothing else breaks.

specific:
- output_types: [requirements, pyproject]
matrices:
- matrix: {cuda: "12.*"}
packages:
- &numba-cuda-cu12-dep numba-cuda[cu12]>=0.14.0,<0.15.0a0
- matrix: # Fallback for no matrix
packages:
- *numba-cuda-cu12-dep
test_python:
common:
- output_types: [conda, requirements, pyproject]
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ license = { text = "Apache-2.0" }
requires-python = ">=3.10"
dependencies = [
"click >=8.1",
"numba-cuda[cu12]>=0.14.0,<0.15.0a0",
"numba>=0.59.1,<0.62.0a0",
"numpy>=1.23,<3.0a0",
"pandas>=1.3",
Expand Down