Skip to content

Add numba-cuda as runtime dependency#1531

Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.10from
pentschev:depend-on-numba-cuda
Aug 8, 2025
Merged

Add numba-cuda as runtime dependency#1531
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.10from
pentschev:depend-on-numba-cuda

Conversation

@pentschev
Copy link
Member

The new numba-cuda package is replacing the old numba.cuda module from the numba package, which is now unmaintained. We recently discovered issues with getting the CUDA context on the new r580 driver that are resolved simply by having numba-cuda installed, therefore make that as a required dependency.

@pentschev pentschev requested a review from a team as a code owner August 8, 2025 10:28
@pentschev pentschev requested a review from bdice August 8, 2025 10:28
@pentschev pentschev added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Aug 8, 2025
@pentschev pentschev self-assigned this Aug 8, 2025
- zict>=2.0.0
- output_types: [conda]
packages:
- &numba-cuda-dep numba-cuda>=0.14.0,<0.15.0a0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to rapidsai/ucxx#481 (comment) ... could we make these >=0.14.0,<0.19, to be compatible with both the current state of cudf the state its about to be in when rapidsai/cudf#19604 is merged?

Then tighten this to >=0.18.0,<0.19 once that cudf PR is merged?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok we talked about this in rapidsai/ucxx#481 (comment) and the answer was "no, not right now".

I'm ok with merging this as-is, thanks for the explanation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xref rapidsai/ucxx#481 (comment):

As a recap, we had to rollback numba-cuda version dependency twice before, immediately this is NOT acceptable IMO. I don’t know if you recall, here's how events unfolded:

  1. First introduced dependency: rapidsai/ucxx@d3aa4a3
  2. Rolled back: rapidsai/ucxx@0f5f99f
  3. And rolled back again: rapidsai/ucxx@41fa142

Since this is a critical issue, that we’ve been seeing segmentation faults in both RAFT and RMM, I think we first need to go the safe route and make sure everything is back to normal, then we can update the pin to a newer version.

Let's play it safe here as well, once we're sure everything is fine with numba-cuda being installed, then we can try a new version and make sure nothing else breaks.

@jameslamb jameslamb self-requested a review August 8, 2025 14:34
Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion for consistency in naming across RAPIDS.

@pentschev
Copy link
Member Author

Thanks all for the reviews.

Just for the sake of completeness here about #1531 (comment), Kyle agreed we should go forward with the current naming and fix with rapids-reviser later if needed. Therefore, I'm triggering an auto-merge.

@pentschev
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 2437b1f into rapidsai:branch-25.10 Aug 8, 2025
28 checks passed
@pentschev pentschev deleted the depend-on-numba-cuda branch August 8, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants