Add numba-cuda as runtime dependency#1531
Add numba-cuda as runtime dependency#1531rapids-bot[bot] merged 3 commits intorapidsai:branch-25.10from
Conversation
| - zict>=2.0.0 | ||
| - output_types: [conda] | ||
| packages: | ||
| - &numba-cuda-dep numba-cuda>=0.14.0,<0.15.0a0 |
There was a problem hiding this comment.
Similar to rapidsai/ucxx#481 (comment) ... could we make these >=0.14.0,<0.19, to be compatible with both the current state of cudf the state its about to be in when rapidsai/cudf#19604 is merged?
Then tighten this to >=0.18.0,<0.19 once that cudf PR is merged?
There was a problem hiding this comment.
Ok we talked about this in rapidsai/ucxx#481 (comment) and the answer was "no, not right now".
I'm ok with merging this as-is, thanks for the explanation.
There was a problem hiding this comment.
xref rapidsai/ucxx#481 (comment):
As a recap, we had to rollback numba-cuda version dependency twice before, immediately this is NOT acceptable IMO. I don’t know if you recall, here's how events unfolded:
- First introduced dependency: rapidsai/ucxx@d3aa4a3
- Rolled back: rapidsai/ucxx@0f5f99f
- And rolled back again: rapidsai/ucxx@41fa142
Since this is a critical issue, that we’ve been seeing segmentation faults in both RAFT and RMM, I think we first need to go the safe route and make sure everything is back to normal, then we can update the pin to a newer version.
Let's play it safe here as well, once we're sure everything is fine with numba-cuda being installed, then we can try a new version and make sure nothing else breaks.
Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>
bdice
left a comment
There was a problem hiding this comment.
Small suggestion for consistency in naming across RAPIDS.
|
Thanks all for the reviews. Just for the sake of completeness here about #1531 (comment), Kyle agreed we should go forward with the current naming and fix with rapids-reviser later if needed. Therefore, I'm triggering an auto-merge. |
|
/merge |
The new
numba-cudapackage is replacing the oldnumba.cudamodule from thenumbapackage, which is now unmaintained. We recently discovered issues with getting the CUDA context on the new r580 driver that are resolved simply by havingnumba-cudainstalled, therefore make that as a required dependency.