Skip to content

Conversation

@pentschev
Copy link
Member

The numba-cuda package was made a dependency in #462, but the conda recipe was missed.

@pentschev pentschev requested a review from a team as a code owner August 8, 2025 10:37
@pentschev pentschev requested a review from jameslamb August 8, 2025 10:37
@pentschev pentschev self-assigned this Aug 8, 2025
@pentschev pentschev added bug Something isn't working non-breaking Introduces a non-breaking change labels Aug 8, 2025
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure that this is the right fix, left some clarifying questions.

run_constraints:
- cupy >=9.5.0
- numba >=0.59.1,<0.62.0a0
- numba-cuda >=0.14.0,<0.15.0a00
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cudf is updating its pinning to >=0.18.0,<0.19.0 in rapidsai/cudf#19604, so this will need to be updated again when that merges (to ensure all of RAPIDS can solve together).

Would it be acceptible to do something like >=0.14.0,<0.19.0 here, so environments that end up with both cudf and ucxx aren't broken? And then tighten it to >=0.18.0,<0.19.0 once that cudf PR is merged? Or is that range too large?

Also, should it be a run: (required) dependency not run_constraints: (optional)? I see that for wheels we only have this as an optional dependency in the [test] extra:

"numba-cuda[cu12]>=0.14.0,<0.15.0a0",

But it seems looks like it's imported unconditionally:

import numba.cuda

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a recap, we had to rollback numba-cuda version dependency twice before, immediately this is NOT acceptable IMO. I don’t know if you recall, here's how events unfolded:

  1. First introduced dependency: d3aa4a3
  2. Rolled back: 0f5f99f
  3. And rolled back again: 41fa142

Since this is a critical issue, that we’ve been seeing segmentation faults in both RAFT and RMM, I think we first need to go the safe route and make sure everything is back to normal, then we can update the pin to a newer version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to run section in a57320f .

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, thank you! Merge any time.

@pentschev
Copy link
Member Author

Thanks @jameslamb and @KyleFromNVIDIA , triggering auto-merge.

@pentschev
Copy link
Member Author

/merge

- pynvml>=12.0.0,<13.0.0a0
- output_types: [conda]
packages:
- &numba-cuda numba-cuda>=0.14.0,<0.15.0a0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to spell this consistently across RAPIDS to make automated updates easier.

Suggested change
- &numba-cuda numba-cuda>=0.14.0,<0.15.0a0
- &numba-cuda-dep numba-cuda>=0.14.0,<0.15.0a0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KyleFromNVIDIA @bdice you should agree here. See rapidsai/dask-cuda#1531 (comment) for the identical discussion in the opposite direction.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdice Most YAML anchors in dependencies.yaml use underscores and don't have -dep at the end. The existing numba-cuda ones are not consistent with everything else. We should fix the existing ones, not make even more inconsistent ones.

@bdice
Copy link
Contributor

bdice commented Aug 8, 2025

I applied my changes (minor renames / typos) since I just saw that /merge had already been triggered.

@pentschev
Copy link
Member Author

Just for the sake of completeness here about #481 (comment), Kyle agreed we should go forward with the current naming and fix with rapids-reviser later if needed.

@rapids-bot rapids-bot bot merged commit 3822555 into rapidsai:branch-0.46 Aug 8, 2025
104 of 106 checks passed
@pentschev pentschev deleted the add-missing-numba-cuda-conda-recipe branch August 8, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants