Skip to content
This repository was archived by the owner on Feb 3, 2025. It is now read-only.

Change numpy pinning to 1.20 - #18

Merged
quasiben merged 1 commit into
rapidsai:mainfrom
charlesbluca:change-numpy-pinning
Dec 3, 2021
Merged

Change numpy pinning to 1.20#18
quasiben merged 1 commit into
rapidsai:mainfrom
charlesbluca:change-numpy-pinning

Conversation

@charlesbluca

Copy link
Copy Markdown
Member

As of NVIDIA/cudf#9687, the latest cuDF / dask-cudf nightlies implicitly require numpy >=1.17,<1.21; this changes our pinning to 1.20 to allow us to grab the latest nightlies again.

cc @pentschev @quasiben

@quasiben

quasiben commented Dec 3, 2021

Copy link
Copy Markdown
Member

I'm approving so we can unblcok CI but I think we should probably remove the pin or set a minimum instead to 1.20.1 rather a true pin

@quasiben
quasiben merged commit 0c77517 into rapidsai:main Dec 3, 2021
@charlesbluca

Copy link
Copy Markdown
Member Author

That makes sense! If this unblocks CI happy to turn this into a constraint

@pentschev

Copy link
Copy Markdown
Member

Yes, I agree, we should set a minimum of NumPy 1.20. I don't see it, where's the implicit pinning to <1.21 coming from in NVIDIA/cudf#9687 ?

@charlesbluca

charlesbluca commented Dec 3, 2021

Copy link
Copy Markdown
Member Author

We bumped numba's minimum version to 0.54, which places additional constraints on Numpy:

$ mamba create -n test -c rapidsai-nightly -c conda-forge "numba>=0.54" numpy=1.21
...
Encountered problems while solving:
  - package numba-0.54.1-py37h51133e4_0 has constraint numpy >=1.17,<1.21 conflicting with numpy-1.21.0-py37h038b26d_0

Versus the older version:

$ mamba create -n test -c rapidsai-nightly -c conda-forge "numba>=0.53.1" numpy=1.21
...
  + numba                0.53.1  py39h56b8d98_1       conda-forge/linux-64        4 MB
  + numpy                1.21.4  py39hdbf815f_0       conda-forge/linux-64        6 MB

@pentschev

Copy link
Copy Markdown
Member

So Numba 0.53 had no constraint on NumPy maximum version, but 0.54 has? Looks a bit odd, but seems due to Python 3.10 support: numba/numba#7563 .

@esc

esc commented Dec 3, 2021

Copy link
Copy Markdown

So Numba 0.53 had no constraint on NumPy maximum version, but 0.54 has? Looks a bit odd, but seems due to Python 3.10 support: numba/numba#7563 .

I think that is correct. NumPy pinning was introduced because future versions were causing breakage. IIRC usually the pin for NumPy is created on release branches.

@pentschev

Copy link
Copy Markdown
Member

Yeah, that makes sense, at first it surprised me but now it's all clear. Thanks @esc for the details! 🙂

@charlesbluca

Copy link
Copy Markdown
Member Author

Looks like the max version here isn't being specified explicitly by Numba either? Inspecting the linux-64 packages, it looks like their max Numpy version is 2.0a0:

image

@pentschev

Copy link
Copy Markdown
Member

I think you only read depends @charlesbluca , as numpy>=1.17,<1.21 is stated in the constraints field.

@charlesbluca

Copy link
Copy Markdown
Member Author

Ah thanks @pentschev, missed that section 😄 to follow up, this resolved Dask's gpuCI, and with #19 and #20 I switched the Numpy pinning to be a minimum version constraint

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants