Change numpy pinning to 1.20 - #18
Conversation
|
I'm approving so we can unblcok CI but I think we should probably remove the pin or set a minimum instead to 1.20.1 rather a true pin |
|
That makes sense! If this unblocks CI happy to turn this into a constraint |
|
Yes, I agree, we should set a minimum of NumPy 1.20. I don't see it, where's the implicit pinning to |
|
We bumped numba's minimum version to 0.54, which places additional constraints on Numpy: Versus the older version: |
|
So Numba 0.53 had no constraint on NumPy maximum version, but 0.54 has? Looks a bit odd, but seems due to Python 3.10 support: numba/numba#7563 . |
I think that is correct. NumPy pinning was introduced because future versions were causing breakage. IIRC usually the pin for NumPy is created on release branches. |
|
Yeah, that makes sense, at first it surprised me but now it's all clear. Thanks @esc for the details! 🙂 |
|
I think you only read |
|
Ah thanks @pentschev, missed that section 😄 to follow up, this resolved Dask's gpuCI, and with #19 and #20 I switched the Numpy pinning to be a minimum version constraint |

As of NVIDIA/cudf#9687, the latest cuDF / dask-cudf nightlies implicitly require
numpy >=1.17,<1.21; this changes our pinning to 1.20 to allow us to grab the latest nightlies again.cc @pentschev @quasiben