Skip to content
This repository was archived by the owner on Feb 3, 2025. It is now read-only.

Change Numpy pinning to min version for all dockerfiles - #20

Merged
charlesbluca merged 1 commit into
rapidsai:mainfrom
charlesbluca:numpy-min-version-2
Dec 3, 2021
Merged

Change Numpy pinning to min version for all dockerfiles#20
charlesbluca merged 1 commit into
rapidsai:mainfrom
charlesbluca:numpy-min-version-2

Conversation

@charlesbluca

Copy link
Copy Markdown
Member

Continuation of #19; for some reason I totally missed the other dockerfiles that needed to be updated 😅

@charlesbluca
charlesbluca merged commit 79e1294 into rapidsai:main Dec 3, 2021
@jakirkham

Copy link
Copy Markdown
Member

Maybe we should refactor these out somehow? Thinking about how we can keep these in one place to simplify updating

@charlesbluca

Copy link
Copy Markdown
Member Author

We could probably pass NUMPY_VER in the actual build script here, and then just have the Dockerfiles have a default version, similar to what we do with most of the other versions:

BUILD_ARGS="--squash --build-arg RAPIDS_VER=$RAPIDS_VER --build-arg UCX_PY_VER=$UCX_PY_VER --build-arg CUDA_VER=$CUDA_VER --build-arg LINUX_VER=$LINUX_VER --build-arg PYTHON_VER=$PYTHON_VER"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants