Use ptxcompiler to patch Numba at runtime to support CUDA enhanced compatibility. by shwina · Pull Request #9687 · NVIDIA/cudf

shwina · 2021-11-15T17:58:20Z

No description provided.

…mpatibility

gmarkall · 2021-11-15T18:45:06Z

This looks good so far on inspection.

gmarkall

It sounds like we're not going to require ptxcompiler for ARM (and not even build the package for it) and just require CUDA 11.5 for it - in that case, I think we'll also need to depend on ptxcompiler conditionally, and guard its use with try ... except ImportError.

…piler

Co-authored-by: Graham Markall <535640+gmarkall@users.noreply.github.com>

jakirkham

Per Graham's question about handling ImportErrors. Maybe the changes below would be sufficient?

jakirkham · 2021-11-18T00:03:07Z

+# Patch Numba to support CUDA enhanced compatibility.
+# See https://github.com/rapidsai/ptxcompiler for
+# details.
+patch_numba_codegen_if_needed()
+del patch_numba_codegen_if_needed
+


Removed as added above

Suggested change

# Patch Numba to support CUDA enhanced compatibility.

# See https://github.com/rapidsai/ptxcompiler for

# details.

patch_numba_codegen_if_needed()

del patch_numba_codegen_if_needed

raydouglass · 2021-11-18T14:10:40Z

@@ -51,6 +51,7 @@ requirements:
    - nvtx >=0.2.1


Don't you need to increase the numba pin in this file as well?

…cec-ptxcompiler

…xcompiler

gmarkall

Looks good to me!

galipremsagar · 2021-11-18T19:36:11Z

rerun tests

…iler

jakirkham · 2021-11-20T23:55:03Z

rerun tests

…compiler

kkraus14 · 2021-11-23T17:46:18Z

This will make cudf change the behavior of Numba on import now, correct? It's a bit of a shame that we're adding additional side effects to importing cudf that are arguably more impactful than the memory allocator side effects we currently have...

gmarkall · 2021-11-23T19:38:59Z

It patches Numba only in an Enhanced Compatibility scenario - when the toolkit version is newer than the driver version. When the driver version is sufficient, no patching occurs. In other words, the only scenario in which Numba is patched is when it wouldn't have worked at all.

In the long term I expect Numba will use ptxcompiler by default, but it also needs a cubin linker than can be linked statically too, which is not available at present. This will give Numba general support for Enhanced Compatibility, so no patch would be needed in any case.

Use ptxcompiler to patch Numba at runtime to support CUDA-enhanced co…

e3ce7cb

…mpatibility

github-actions Bot added conda Python Affects Python cuDF API. labels Nov 15, 2021

shwina commented Nov 15, 2021

View reviewed changes

Comment thread conda/environments/cudf_dev_cuda11.0.yml Outdated

gmarkall reviewed Nov 16, 2021

View reviewed changes

Comment thread python/cudf/cudf/__init__.py Outdated

shwina added 3 commits November 16, 2021 08:41

del function that we don't want to expose

7f5c4b9

Newlines

c06cda2

Newlines

3438bdd

shwina changed the title ~~Use ptxcompiler to patch Numba at runtime to support CUDA-enhanced compatibility.~~ Use ptxcompiler to patch Numba at runtime to support CUDA enhanced compatibility. Nov 16, 2021

shwina added 3 commits November 16, 2021 15:59

Don't use debug=True in numba kernels

61ff5f2

Describe change

17287cb

Improve description

97c6946

galipremsagar reviewed Nov 16, 2021

View reviewed changes

Comment thread conda/recipes/cudf/meta.yaml Outdated

Change numba version

95963f5

gmarkall reviewed Nov 16, 2021

View reviewed changes

Comment thread python/cudf/cudf/tests/test_extension_compilation.py Outdated

gmarkall reviewed Nov 16, 2021

View reviewed changes

Comment thread python/cudf/cudf/tests/test_extension_compilation.py

Remove raise

9c66ae3

gmarkall suggested changes Nov 16, 2021

View reviewed changes

galipremsagar added 3 commits November 16, 2021 17:47

fix pytests for latest numpy

9aebb54

Merge remote-tracking branch 'ashwin/cec-ptxcompiler' into cec-ptxcom…

5415889

…piler

upgrade clang to 11.1.0

9eb1579

galipremsagar mentioned this pull request Nov 17, 2021

[REVIEW] Upgrade clang to 11.1.0 #9716

Merged

galipremsagar reviewed Nov 17, 2021

View reviewed changes

Comment thread python/cudf/cudf/tests/test_extension_compilation.py

gmarkall reviewed Nov 17, 2021

View reviewed changes

Comment thread python/cudf/cudf/tests/test_extension_compilation.py Outdated

Update python/cudf/cudf/tests/test_extension_compilation.py

b192ab9

Co-authored-by: Graham Markall <535640+gmarkall@users.noreply.github.com>

shwina commented Nov 17, 2021

View reviewed changes

Comment thread conda/environments/cudf_dev_cuda11.2.yml Outdated

shwina commented Nov 17, 2021

View reviewed changes

Comment thread conda/environments/cudf_dev_cuda11.5.yml Outdated

shwina commented Nov 17, 2021

View reviewed changes

Comment thread conda/recipes/cudf/meta.yaml Outdated

jakirkham reviewed Nov 18, 2021

View reviewed changes

shwina marked this pull request as ready for review November 18, 2021 14:04

shwina requested review from a team as code owners November 18, 2021 14:04

shwina requested review from ramakrishnap-nv and skirui-source and removed request for a team November 18, 2021 14:04

raydouglass added feature request New feature or request non-breaking Non-breaking change labels Nov 18, 2021

raydouglass suggested changes Nov 18, 2021

View reviewed changes

Change numba pin

3675c0c

raydouglass approved these changes Nov 18, 2021

View reviewed changes

shwina added 2 commits November 18, 2021 10:04

Merge branch 'branch-21.12' of https://github.com/rapidsai/cudf into …

6113dd7

…cec-ptxcompiler

Merge remote-tracking branch 'galipremsagar/clang_11.1.0' into cec-pt…

6a8a8bb

…xcompiler

gmarkall approved these changes Nov 18, 2021

View reviewed changes

jakirkham approved these changes Nov 18, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/branch-21.12' into cec-ptxcomp…

2334d95

…iler

shwina and others added 6 commits November 22, 2021 10:33

Update conda/environments/cudf_dev_cuda11.5.yml

8455c60

Update conda/environments/cudf_dev_cuda11.2.yml

f8019de

Update conda/recipes/cudf/meta.yaml

65da07d

Merge branch 'cec-ptxcompiler' of github.com:shwina/cudf into cec-ptx…

6279f6e

…compiler

Merge branch 'cec-ptxcompiler' of github.com:shwina/cudf into cec-ptx…

c741e1d

…compiler

One more linux64

69dca77

ajschmidt8 approved these changes Nov 29, 2021

View reviewed changes

ajschmidt8 merged commit a1ca8c1 into NVIDIA:branch-21.12 Nov 29, 2021

This was referenced Dec 3, 2021

Change numpy pinning to 1.20 rapidsai/dask-build-environment#18

Merged

[WIP] Attempt to resolve gpuCI breakage dask-contrib/dask-sql#340

Closed

Uh oh!

Conversation

shwina commented Nov 15, 2021

Uh oh!

gmarkall commented Nov 15, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmarkall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakirkham left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jakirkham Nov 18, 2021

Choose a reason for hiding this comment

Uh oh!

raydouglass Nov 18, 2021

Choose a reason for hiding this comment

Uh oh!

shwina Nov 18, 2021

Choose a reason for hiding this comment

Uh oh!

gmarkall left a comment

Choose a reason for hiding this comment

Uh oh!

galipremsagar commented Nov 18, 2021

Uh oh!

jakirkham commented Nov 20, 2021

Uh oh!

kkraus14 commented Nov 23, 2021

Uh oh!

gmarkall commented Nov 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants