Revert to having NCCL linkage as PRIVATE CMake option #1395
Closed
divyegala wants to merge 2 commits intorapidsai:branch-25.10from
Closed
Revert to having NCCL linkage as PRIVATE CMake option #1395divyegala wants to merge 2 commits intorapidsai:branch-25.10from
NCCL linkage as PRIVATE CMake option #1395divyegala wants to merge 2 commits intorapidsai:branch-25.10from
Conversation
divyegala
added
bug
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
github-project-automation
bot
moved this from Todo
to Done
in Vector Search, ML, & Data Mining Release Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced in #1317, this caused us to see test failures in cuML as described in rapidsai/cuml#7277.
During the triaging process, we found out the cause was
libcuml++.sorequiring a dynamic link tolibnccl.so, and it was picking up an older system installation of the aforementioned instead of the wheel. But, we believe that the correct fix is that cuVS stop leaking its NCCL dependency.cc @csadorf