Skip to content

Refactor CMakeLists to support static only builds of libcuvs#1317

Merged
rapids-bot[bot] merged 9 commits intorapidsai:branch-25.10from
robertmaynard:bug/support_static_only_builds
Sep 17, 2025
Merged

Refactor CMakeLists to support static only builds of libcuvs#1317
rapids-bot[bot] merged 9 commits intorapidsai:branch-25.10from
robertmaynard:bug/support_static_only_builds

Conversation

@robertmaynard
Copy link
Contributor

@robertmaynard robertmaynard commented Sep 5, 2025

Fixes: #1312
Fixes: #1322

Supports: #1241

If you want a shared libcuvs but static RAPIDS dependencies ( raft, rmm, logger, .... ). You can use CUVS_STATIC_RAPIDS_LIBRARIES=ON with CUVS_COMPILE_DYNAMIC_ONLY=ON. If you want a fully static cuvs and dependencies you can use BUILD_SHARED_LIBS=OFF ( CUVS_STATIC_RAPIDS_LIBRARIES is not needed but can also be set to ON )

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 5, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change labels Sep 5, 2025
@robertmaynard
Copy link
Contributor Author

/okay to test

@robertmaynard robertmaynard force-pushed the bug/support_static_only_builds branch from 53e878f to 4ceb12e Compare September 5, 2025 15:46
@robertmaynard
Copy link
Contributor Author

/okay to test

@robertmaynard robertmaynard force-pushed the bug/support_static_only_builds branch from 4ceb12e to 7b66309 Compare September 5, 2025 16:01
@robertmaynard
Copy link
Contributor Author

/okay to test

@robertmaynard
Copy link
Contributor Author

/okay to test

@robertmaynard robertmaynard force-pushed the bug/support_static_only_builds branch from ab6f266 to a4efb8a Compare September 8, 2025 13:54
@robertmaynard
Copy link
Contributor Author

/okay to test

@robertmaynard
Copy link
Contributor Author

/okay to test

@robertmaynard
Copy link
Contributor Author

/okay to test

@robertmaynard robertmaynard changed the title Support static only builds of libcuvs Refactor CMakeLists to support static only builds of libcuvs Sep 8, 2025
@robertmaynard robertmaynard marked this pull request as ready for review September 9, 2025 14:02
@robertmaynard robertmaynard requested a review from a team as a code owner September 9, 2025 14:02
@cjnolet
Copy link
Member

cjnolet commented Sep 17, 2025

/merge

@rapids-bot rapids-bot bot merged commit 5492a06 into rapidsai:branch-25.10 Sep 17, 2025
84 checks passed
@robertmaynard robertmaynard deleted the bug/support_static_only_builds branch December 3, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Development

Successfully merging this pull request may close these issues.

[BUG] CMake build flag DISABLE_OPENMP doesn't actually disable OpenMP [BUG] BUILD_SHARED_LIBS=OFF disables all building of CUVS

2 participants