Skip to content

Revert to having NCCL linkage as PRIVATE CMake option #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
divyegala wants to merge 2 commits into from
Closed

Revert to having NCCL linkage as PRIVATE CMake option #1395

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
639e988
nccl PRIVATE
divyegala Sep 29, 2025
11eede0
Merge branch 'branch-25.10' into undo-nccl-leak
cjnolet Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ if(NOT BUILD_CPU_ONLY)
LIBRARY_NAMES nccl
)
find_package(NCCL REQUIRED)
target_link_libraries(cuvs_objs PUBLIC $<BUILD_LOCAL_INTERFACE:NCCL::NCCL>)
target_link_libraries(cuvs_objs PRIVATE $<BUILD_LOCAL_INTERFACE:NCCL::NCCL>)

target_compile_definitions(cuvs_objs PUBLIC CUVS_BUILD_MG_ALGOS)
target_compile_definitions(cuvs-cagra-search PUBLIC CUVS_BUILD_MG_ALGOS)
Expand Down Expand Up @@ -622,11 +622,10 @@ if(NOT BUILD_CPU_ONLY)
PUBLIC rmm::rmm
raft::raft
${CUVS_CTK_MATH_DEPENDENCIES}
$<BUILD_LOCAL_INTERFACE:$<TARGET_NAME_IF_EXISTS:NCCL::NCCL>>
$<BUILD_LOCAL_INTERFACE:$<TARGET_NAME_IF_EXISTS:hnswlib::hnswlib>>
$<$<BOOL:${CUVS_NVTX}>:CUDA::nvtx3>
PRIVATE nvidia::cutlass::cutlass $<TARGET_NAME_IF_EXISTS:OpenMP::OpenMP_CXX>
cuvs-cagra-search
cuvs-cagra-search $<BUILD_LOCAL_INTERFACE:$<TARGET_NAME_IF_EXISTS:NCCL::NCCL>>
)

# ensure CUDA symbols aren't relocated to the middle of the debug build binaries
Expand Down Expand Up @@ -683,10 +682,10 @@ SECTIONS
PUBLIC rmm::rmm
raft::raft
${CUVS_CTK_MATH_DEPENDENCIES}
$<BUILD_LOCAL_INTERFACE:$<TARGET_NAME_IF_EXISTS:NCCL::NCCL>>
$<BUILD_LOCAL_INTERFACE:$<TARGET_NAME_IF_EXISTS:hnswlib::hnswlib>>
$<$<BOOL:${CUVS_NVTX}>:CUDA::nvtx3>
PRIVATE nvidia::cutlass::cutlass $<TARGET_NAME_IF_EXISTS:OpenMP::OpenMP_CXX>
$<BUILD_LOCAL_INTERFACE:$<TARGET_NAME_IF_EXISTS:NCCL::NCCL>>
)
endif()

Expand Down