Skip to content
This repository was archived by the owner on Sep 25, 2023. It is now read-only.

Gpuciscripts clean and update - #283

Merged
awthomp merged 7 commits into
rapidsai:branch-0.17from
msadang:gpuciscripts-update
Dec 4, 2020
Merged

Gpuciscripts clean and update#283
awthomp merged 7 commits into
rapidsai:branch-0.17from
msadang:gpuciscripts-update

Conversation

@msadang

@msadang msadang commented Nov 10, 2020

Copy link
Copy Markdown
Contributor

In CI folder the following changes have been made:

  • Remove logger function and replace all logger calls with gpuci_logger

  • Removed all ellipses ... from logger messages

  • Prepend /opt to the conda path in PATH variable

  • Replace conda with gpuci_conda_retry for build and install calls (Did not replace conda activate with gpuci_conda_retry)

  • Replace source activate with the following:
    . /opt/conda/etc/profile.d/conda.sh
    conda activate rapids

  • Replace conda list with more verbose information:
    conda info
    conda config --show-sources
    conda list --show-channel-urls

  • Update Copyright year in the top of scripts to include 2020 if applicable

  • Set PARALLEL_LEVEL to ${PARALLEL_LEVEL:-4}

  • Set gpuci_conda_retry flags in cpu/build.sh
    Setup 'gpuci_conda_retry' for build retries (results in 2 total attempts)
    export GPUCI_CONDA_RETRY_MAX=1
    export GPUCI_CONDA_RETRY_SLEEP=30

  • Replace calls to gcc and g++ with $CC and $CXX respectively

@msadang
msadang requested a review from a team as a code owner November 10, 2020 01:58
@GPUtester

Copy link
Copy Markdown
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@ajschmidt8 ajschmidt8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like my review comments from the raft PR below will apply here as well (remove gpuci_logger function and fix export PARALLEL_LEVEL=${PARALLEL_LEVEL:-4}).

NVIDIA/raft#92 (review)

@ajschmidt8 ajschmidt8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like my review comments from the raft PR below will apply here as well (remove gpuci_logger function and fix export PARALLEL_LEVEL=${PARALLEL_LEVEL:-4}).

NVIDIA/raft#92 (review)

@dillon-cullinan

Copy link
Copy Markdown
Contributor

Should pull in the latest updates on the git repo, many of these changes are already reflected here: #275

@BradReesWork BradReesWork added the improvement Improvement / enhancement to an existing function label Nov 11, 2020
@BradReesWork BradReesWork added this to the 0.17 milestone Nov 11, 2020
@msadang

msadang commented Nov 13, 2020

Copy link
Copy Markdown
Contributor Author

It looks like my review comments from the raft PR below will apply here as well (remove gpuci_logger function and fix export PARALLEL_LEVEL=${PARALLEL_LEVEL:-4}).

rapidsai/raft#92 (review)

gpuci_logger and parallel level changed.

@msadang msadang added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change gpuCI improvement Improvement / enhancement to an existing function feature request New feature or request and removed improvement Improvement / enhancement to an existing function labels Dec 3, 2020
@msadang msadang changed the title [WIP] - Gpuciscripts clean and update Gpuciscripts clean and update Dec 3, 2020
@msadang msadang removed the feature request New feature or request label Dec 3, 2020
@msadang msadang added the feature request New feature or request label Dec 3, 2020
@awthomp
awthomp merged commit d6175e1 into rapidsai:branch-0.17 Dec 4, 2020
@msadang
msadang deleted the gpuciscripts-update branch December 9, 2020 19:54
@msadang
msadang restored the gpuciscripts-update branch December 9, 2020 19:54
@msadang
msadang deleted the gpuciscripts-update branch December 9, 2020 19:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3 - Ready for Review Ready for review by team feature request New feature or request gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants