Gpuciscripts clean and update - #92
Merged
Merged
Conversation
Contributor
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
ajschmidt8
requested changes
Nov 10, 2020
ajschmidt8
left a comment
ajschmidt8
left a comment
Member
There was a problem hiding this comment.
looks good so far. I found a few things that will need to be changed. Dillon's rmm PR below is a good reference (just ignore the project flash specific stuff).
https://github.com/rapidsai/rmm/pull/615/files
dillon-cullinan
suggested changes
Nov 10, 2020
This was referenced Nov 13, 2020
Contributor
Author
|
gpuci_logger and parallel level changed. |
ajschmidt8
approved these changes
Nov 16, 2020
dillon-cullinan
approved these changes
Nov 18, 2020
msadang
added
improvement
msadang
changed the title
dantegd
pushed a commit
to dantegd/raft
that referenced
this pull request
Jul 23, 2024
## What SSIA Authors: - Shunya Ueta (https://github.com/hurutoriya) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Jake Awe (https://github.com/AyodeAwe) URL: NVIDIA/cuvs#92
loulankxh
pushed a commit
to loulankxh/raft
that referenced
this pull request
Oct 14, 2025
In CI folder the following changes have been made:
- Remove logger function and replace all logger calls with gpuci_logger
- Removed all ellipses ... from logger messages
- Prepend /opt to the conda path in PATH variable
- Replace conda with gpuci_conda_retry for build and install calls (Did not replace conda activate with gpuci_conda_retry)
- Replace source activate <env> with the following:
. /opt/conda/etc/profile.d/conda.sh
conda activate rapids
- Replace conda list with more verbose information:
conda info
conda config --show-sources
conda list --show-channel-urls
- Update Copyright year in the top of scripts to include 2020 if applicable
- Set PARALLEL_LEVEL to ${PARALLEL_LEVEL:-4}
- Set gpuci_conda_retry flags in cpu/build.sh
Setup 'gpuci_conda_retry' for build retries (results in 2 total attempts)
export GPUCI_CONDA_RETRY_MAX=1
export GPUCI_CONDA_RETRY_SLEEP=30
- Replace calls to gcc and g++ with $CC and $CXX respectively
Authors:
- Mark Sadang <msadang@nvidia.com>
- Mark Sadang <marksadang@engineer.com>
- Mark Sadang <63854412+msadang@users.noreply.github.com>
Approvers:
- AJ Schmidt
- Dillon Cullinan
URL: NVIDIA#92
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CI folder the following changes have been made:
Remove logger function and replace all logger calls with gpuci_logger
Removed all ellipses ... from logger messages
Prepend /opt to the conda path in PATH variable
Replace conda with gpuci_conda_retry for build and install calls (Did not replace conda activate with gpuci_conda_retry)
Replace source activate with the following:
. /opt/conda/etc/profile.d/conda.sh
conda activate rapids
Replace conda list with more verbose information:
conda info
conda config --show-sources
conda list --show-channel-urls
Update Copyright year in the top of scripts to include 2020 if applicable
Set PARALLEL_LEVEL to ${PARALLEL_LEVEL:-4}
Set gpuci_conda_retry flags in cpu/build.sh
Setup 'gpuci_conda_retry' for build retries (results in 2 total attempts)
export GPUCI_CONDA_RETRY_MAX=1
export GPUCI_CONDA_RETRY_SLEEP=30
Replace calls to gcc and g++ with $CC and $CXX respectively