This repository was archived by the owner on Sep 25, 2023. It is now read-only.
[REVIEW] ENH Improve gpuCI scripts - #275
Merged
Merged
Conversation
Contributor
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
ajschmidt8
suggested changes
Oct 23, 2020
ajschmidt8
left a comment
ajschmidt8
left a comment
Member
There was a problem hiding this comment.
looks good, just found an old TODO block that can be removed from the docs/build.sh script
Comment on lines
33
to
35
| # TODO: Move installs to docs-build-env meta package | ||
| conda install -c anaconda markdown beautifulsoup4 jq | ||
| gpuci_conda_retry install -c anaconda markdown beautifulsoup4 jq | ||
| pip install sphinx-markdown-tables |
Member
There was a problem hiding this comment.
similarly to the comment on Mike's PR below, this whole TODO block can be removed. I see sphinx-markdown-tables, markdown and beautifulsoup4 in the rapids-doc-env and jq in our gpuci devel images.
BradReesWork
approved these changes
Oct 28, 2020
ajschmidt8
approved these changes
Oct 28, 2020
ajschmidt8
left a comment
ajschmidt8
left a comment
Member
There was a problem hiding this comment.
one last item here can be removed, LGTM otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
First step before "Project Flash" to improve gpuCI scripts and allow for use of different node types for CPU builds. Post "Project Flash" there will be another round of improvements and updates with the goal to make these scripts easier to maintain.
Changes