Skip to content

Avoid modifying a std::move-ed out object #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seunghwak wants to merge 4 commits into from
Closed

Avoid modifying a std::move-ed out object #5395

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c18ca08
bug fix
seunghwak Jan 13, 2026
41efd51
Merge branch 'main' of https://github.com/rapidsai/cugraph into bug_a…
seunghwak Jan 13, 2026
b7c0f7e
Update cpp/src/traversal/od_shortest_distances_impl.cuh
seunghwak Jan 14, 2026
66e233a
Update cpp/src/traversal/od_shortest_distances_impl.cuh
seunghwak Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cpp/src/traversal/od_shortest_distances_impl.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2024-2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/
#pragma once
Expand Down Expand Up @@ -912,7 +912,8 @@ rmm::device_uvector<weight_t> od_shortest_distances(
h_split_thresholds.size(),
handle.get_stream());

rmm::device_uvector<key_t> tmp_buffer = std::move(far_buffers.back());
auto tmp_buffer = rmm::device_uvector<key_t>(0, handle.get_stream());
std::swap(tmp_buffer, far_buffers.back());
std::vector<key_t*> h_buffer_ptrs(h_split_thresholds.size() + 1);
auto old_size = new_near_q_keys.size();
for (size_t j = 0; j < h_buffer_ptrs.size(); ++j) {
Expand Down Expand Up @@ -994,7 +995,8 @@ rmm::device_uvector<weight_t> od_shortest_distances(
new_near_q_keys.resize(cuda::std::distance(new_near_q_keys.begin(), last),
handle.get_stream());
} else {
far_buffers[i - num_near_q_insert_buffers] = std::move(far_buffers[i]);
std::swap(far_buffers[i - num_near_q_insert_buffers], far_buffers[i]);
far_buffers[i].resize(0, handle.get_stream());
}
}

Expand Down
Loading