When bundling libnvcomp.so.X only append the major version value#19786
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.10from Aug 25, 2025
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/okay to test 60e8205 |
robertmaynard
added
bug
robertmaynard
force-pushed
the
debug_wheel_load_failures
branch
from
60e8205 to
1c25c27
Compare
Contributor
Author
|
/okay to test 1c25c27 |
Contributor
Author
|
/okay to test 23ac00b |
robertmaynard
force-pushed
the
debug_wheel_load_failures
branch
from
23ac00b to
2d69e5c
Compare
Contributor
Author
|
/okay to test 2d69e5c |
Contributor
Author
|
/okay to test 013af0b |
We previously extracted the whole X.Y.Z.P version string of nvcomp and would therefore fail to load the correct version in our wheel packages.
robertmaynard
force-pushed
the
debug_wheel_load_failures
branch
from
013af0b to
35347d5
Compare
robertmaynard
changed the title
libnvcomp.so.X only append the major version value
KyleFromNVIDIA
approved these changes
Aug 25, 2025
3 tasks
Contributor
|
/merge |
This was referenced Aug 25, 2025
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/cudf
that referenced
this pull request
Aug 25, 2025
Resolves rapidsai#19790 Follow-up to rapidsai#19786
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
Resolves #19790 Follow-up to #19786 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Nghia Truong (https://github.com/ttnghia) URL: #19791
galipremsagar
pushed a commit
to galipremsagar/cudf
that referenced
this pull request
Aug 27, 2025
…apidsai#19786) We previously extracted the whole X.Y.Z.P version string of nvcomp and would therefore fail to load the correct version in our wheel packages. Authors: - Robert Maynard (https://github.com/robertmaynard) - Bradley Dice (https://github.com/bdice) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: rapidsai#19786
galipremsagar
pushed a commit
to galipremsagar/cudf
that referenced
this pull request
Aug 27, 2025
Resolves rapidsai#19790 Follow-up to rapidsai#19786 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Nghia Truong (https://github.com/ttnghia) URL: rapidsai#19791
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We previously extracted the whole X.Y.Z.P version string of nvcomp and would therefore fail to load the correct version in our wheel packages.
Checklist