Disable shallow clone for Jitify dependency in CMake configuration#19784
Disable shallow clone for Jitify dependency in CMake configuration#19784a-hirota wants to merge 1 commit intorapidsai:branch-25.10from
Conversation
Change GIT_SHALLOW from TRUE to FALSE to ensure complete repository history is available during build. This improves build stability by providing access to the complete Git history when needed.
There was a problem hiding this comment.
Pull Request Overview
This PR disables shallow clone for the Jitify dependency in CMake configuration by changing GIT_SHALLOW from TRUE to FALSE. This ensures the complete Git repository history is available during the build process, which can improve build stability when the build system requires access to the full repository history.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
/ok to test |
@davidwendt, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
|
/ok to test 085b71b |
|
@TomAugspurger Thank you for incorporating this change in #19786! I've tested branch-25.10 and can confirm:
Everything looks good to me. Should I close this PR since the fix is now included in #19786? |
|
Yep, I think we're all set now. Thanks for making the PR, and sorry we didn't get it in before those other issues came up. |
Description
Change GIT_SHALLOW from TRUE to FALSE to ensure complete repository history is available during build. This improves build stability by providing access to the complete Git history when needed.
This change affects the Jitify dependency configuration in
cpp/cmake/thirdparty/get_jitify.cmakeand helps prevent potential build issues that may occur when the build system requires access to the full Git repository history.Checklist