Skip to content

Comments

Disable shallow clone for Jitify dependency in CMake configuration#19784

Closed
a-hirota wants to merge 1 commit intorapidsai:branch-25.10from
a-hirota:jitify-update-clean
Closed

Disable shallow clone for Jitify dependency in CMake configuration#19784
a-hirota wants to merge 1 commit intorapidsai:branch-25.10from
a-hirota:jitify-update-clean

Conversation

@a-hirota
Copy link
Contributor

Description

Change GIT_SHALLOW from TRUE to FALSE to ensure complete repository history is available during build. This improves build stability by providing access to the complete Git history when needed.

This change affects the Jitify dependency configuration in cpp/cmake/thirdparty/get_jitify.cmake and helps prevent potential build issues that may occur when the build system requires access to the full Git repository history.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Change GIT_SHALLOW from TRUE to FALSE to ensure complete repository
history is available during build. This improves build stability by
providing access to the complete Git history when needed.
Copilot AI review requested due to automatic review settings August 24, 2025 15:50
@a-hirota a-hirota requested a review from a team as a code owner August 24, 2025 15:50
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 24, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables shallow clone for the Jitify dependency in CMake configuration by changing GIT_SHALLOW from TRUE to FALSE. This ensures the complete Git repository history is available during the build process, which can improve build stability when the build system requires access to the full repository history.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 24, 2025
@davidwendt
Copy link
Contributor

/ok to test

@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 24, 2025

/ok to test

@davidwendt, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@davidwendt
Copy link
Contributor

/ok to test 085b71b

@bdice
Copy link
Contributor

bdice commented Aug 25, 2025

Thank you @a-hirota! I would like to merge #19783 instead. It also contains a separate fix that is needed.

@TomAugspurger
Copy link
Contributor

@a-hirota #19786 ended up including this change to get CI passing. Would you be able to pull branch-25.10 and confirm that things work for you?

@a-hirota
Copy link
Contributor Author

@TomAugspurger Thank you for incorporating this change in #19786!

I've tested branch-25.10 and can confirm:

  • The build completes successfully with the Jitify update
  • No build errors encountered

Everything looks good to me. Should I close this PR since the fix is now included in #19786?

@TomAugspurger
Copy link
Contributor

Yep, I think we're all set now. Thanks for making the PR, and sorry we didn't get it in before those other issues came up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants