Skip to content

When bundling libnvcomp.so.X only append the major version value #19786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 3 commits into from
Aug 25, 2025
Merged

When bundling libnvcomp.so.X only append the major version value #19786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b961fd
Update to jitify with CUDA 13 fix
bdice Aug 23, 2025
a12823b
Merge branch 'branch-25.10' into update-jitify
bdice Aug 23, 2025
35347d5
Correctly install nvcomp as `libnvcomp.so.X.`
robertmaynard Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/cmake/thirdparty/get_jitify.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ function(find_and_configure_jitify)
rapids_cpm_find(
jitify 2.0.0
GIT_REPOSITORY https://github.com/NVIDIA/jitify.git
GIT_TAG 70783a3ad7b0cad2992a26a1ebf8fbe3d6b44e25 # jitify2 branch as of 5th Aug 2025
GIT_SHALLOW TRUE
GIT_TAG 44e978b21fc8bdb6b2d7d8d179523c8350db72e5 # jitify2 branch as of 23rd Aug 2025
GIT_SHALLOW FALSE
DOWNLOAD_ONLY TRUE
)
set(JITIFY_INCLUDE_DIR
Expand Down
6 changes: 4 additions & 2 deletions python/libcudf/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,13 @@ if(TARGET nvcomp::nvcomp)
# Compute the SOVERSION from the library path
get_filename_component(nvcomp_lib_dir ${nvcomp_lib_path} DIRECTORY)
get_filename_component(nvcomp_lib_name ${nvcomp_lib_path} NAME)
string(REGEX REPLACE "libnvcomp\\.so\\.([0-9]+)" "\\1" nvcomp_soversion ${nvcomp_lib_name})
string(REPLACE [=[libnvcomp.so.]=] "" nvcomp_soversion ${nvcomp_lib_name})
string(REPLACE [=[.]=] ";" nvcomp_soversion ${nvcomp_soversion})
list(GET nvcomp_soversion 0 nvcomp_soversion_major)
install(
FILES ${nvcomp_lib_path}
DESTINATION ${SKBUILD_PLATLIB_DIR}/libcudf/lib64/
RENAME libnvcomp.so.${nvcomp_soversion}
RENAME libnvcomp.so.${nvcomp_soversion_major}
)
else()
message(FATAL_ERROR "nvcomp target must be imported")
Expand Down