Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partitioning possibilities in YIP #219

Closed
davidcassany opened this issue May 27, 2021 · 0 comments · Fixed by mudler/yip#8 or #1498
Closed

Partitioning possibilities in YIP #219

davidcassany opened this issue May 27, 2021 · 0 comments · Fixed by mudler/yip#8 or #1498
Assignees

Comments

@davidcassany
Copy link
Contributor

davidcassany commented May 27, 2021

This card is about adding a plugin in YIP that is capable to create the COS_STATE partition and COS_PERSISTENT partition into the unpartitioned free space of a disk to some customizable sizes and filesystems (even if we only use ext we should already consider this option). I believe we should consider this three values for partition creation:

  • label
  • size
  • filesystem

Note that for that it might be required to expand the partition table. Also having the option to expand already existing partitions would be a plus.

Note the code create here could be reused by #108 or viceversa.

@davidcassany davidcassany self-assigned this Jun 3, 2021
davidcassany added a commit to mudler/yip that referenced this issue Jun 4, 2021
The Layout plugin mostly allows to expand the last partition to the disk
geometry and/or add additional partitions over the unpartitioned space.

In case there is no unpartitioned space on disk no changes are applied.

Fixes rancher/elemental-toolkit#219

Signed-off-by: David Cassany <[email protected]>
davidcassany added a commit to mudler/yip that referenced this issue Jun 9, 2021
The Layout plugin mostly allows to expand the last partition to the disk
geometry and/or add additional partitions over the unpartitioned space.

In case there is no unpartitioned space on disk no changes are applied.

Fixes rancher/elemental-toolkit#219

Signed-off-by: David Cassany <[email protected]>
davidcassany added a commit to mudler/yip that referenced this issue Jun 10, 2021
The Layout plugin mostly allows to expand the last partition to the disk
geometry and/or add additional partitions over the unpartitioned space.

In case there is no unpartitioned space on disk no changes are applied.

Fixes rancher/elemental-toolkit#219

Signed-off-by: David Cassany <[email protected]>
davidcassany added a commit to mudler/yip that referenced this issue Jun 10, 2021
The Layout plugin mostly allows to expand the last partition to the disk
geometry and/or add additional partitions over the unpartitioned space.

In case there is no unpartitioned space on disk no changes are applied.

Fixes rancher/elemental-toolkit#219

Signed-off-by: David Cassany <[email protected]>
mjura added a commit to mjura/elemental-toolkit that referenced this issue Jun 9, 2022
mudler pushed a commit that referenced this issue Jun 9, 2022
frelon pushed a commit to frelon/elemental-toolkit that referenced this issue May 12, 2023
* build-iso: Improve validation for rootfs source image

For build-iso subcommand improve validation of source image argument,
as default set it as container image with "latest" tag if empty.

For LiveISO struct change types for RootFS, UEFI, Image to []*ImageSource.

Fixes rancher#219

Signed-off-by: Michal Jura <[email protected]>

* docs: elemental build-iso SOURCE [flags]

SOURCE - should be provided as uri in following format <sourceType>:<sourceName>
    * <sourceType> - might be one of ["dir", "file", "oci", "docker", "channel"], default is "docker"
    * <sourceName> - is path to file or directory, image name with tag version or channel name

Fixes rancher#219

Signed-off-by: Michal Jura <[email protected]>
frelon pushed a commit to frelon/elemental-toolkit that referenced this issue May 12, 2023
We would like to remove and stop using NewSourceGuessingType(),
instead of it NewSrcFromURI() shoud be used from
github.com/rancher/elemental-cli/pkg/types/v1

Fixes rancher#219

Signed-off-by: Michal Jura <[email protected]>
frelon pushed a commit to frelon/elemental-toolkit that referenced this issue May 12, 2023
All source packages in config file for build-iso,
have to be provided in uri format with prefix "dir", "file",
"oci", "docker", "channel" (e.g. channel:live/grub2-efi-image)

Fixes rancher#219

Signed-off-by: Michal Jura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant