Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new luet-mtree event for upgrade checks #251

Merged
merged 7 commits into from
Jun 21, 2021

Conversation

Itxaka
Copy link
Contributor

@Itxaka Itxaka commented Jun 9, 2021

We were using a bash script to call luet-mtree on upgrade to check for
valid mtree checksums.

luet-mtree 0.0.6 now supports working with events from luet itself,
which will do the same as the bash script and extract the image metadata
to check the mtree checksums.

This patch removes the old bash script and uses the luet-mtree plugin
directly to check the checksums, it also bumps luet-mtree to 0.0.6

Signed-off-by: Itxaka [email protected]

@Itxaka Itxaka changed the title Use the new luet-mtree event for upgrade checks [wip] Use the new luet-mtree event for upgrade checks Jun 9, 2021
@Itxaka Itxaka changed the title [wip] Use the new luet-mtree event for upgrade checks Use the new luet-mtree event for upgrade checks Jun 10, 2021
Copy link
Contributor

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Itxaka
Copy link
Contributor Author

Itxaka commented Jun 10, 2021

blocked by #254

@Itxaka
Copy link
Contributor Author

Itxaka commented Jun 11, 2021

test keep failing but locally they pass :/

@Itxaka Itxaka force-pushed the use_new_luet branch 3 times, most recently from c9a3a09 to 736c021 Compare June 11, 2021 20:16
@Itxaka Itxaka changed the title Use the new luet-mtree event for upgrade checks [WIP]Use the new luet-mtree event for upgrade checks Jun 15, 2021
@Itxaka
Copy link
Contributor Author

Itxaka commented Jun 15, 2021

Argh, recovery is failing due to the plugin probably! setting this to wip

@Itxaka Itxaka changed the title [WIP]Use the new luet-mtree event for upgrade checks Use the new luet-mtree event for upgrade checks Jun 15, 2021
@Itxaka Itxaka force-pushed the use_new_luet branch 2 times, most recently from 4d8366f to 3bcbaf9 Compare June 16, 2021 15:02
We were using a bash script to call luet-mtree on upgrade to check for
valid mtree checksums.

luet-mtree 0.0.6 now supports working with events from luet itself,
which will do the same as the bash script and extract the image metadata
to check the mtree checksums.

This patch removes the old bash script and uses the luet-mtree plugin
directly to check the checksums, it also bumps luet-mtree to 0.0.6

Signed-off-by: Itxaka <[email protected]>
@mudler mudler merged commit 7b0bf09 into rancher:master Jun 21, 2021
frelon pushed a commit to frelon/elemental-toolkit that referenced this pull request May 12, 2023
All source packages in config file for build-iso,
have to be provided in uri format with prefix "dir", "file",
"oci", "docker", "channel" (e.g. channel:live/grub2-efi-image)

Fixes rancher#219

Signed-off-by: Michal Jura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants