-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new luet-mtree event for upgrade checks #251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itxaka
changed the title
Use the new luet-mtree event for upgrade checks
[wip] Use the new luet-mtree event for upgrade checks
Jun 9, 2021
Itxaka
changed the title
[wip] Use the new luet-mtree event for upgrade checks
Use the new luet-mtree event for upgrade checks
Jun 10, 2021
mudler
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
blocked by #254 |
test keep failing but locally they pass :/ |
Itxaka
force-pushed
the
use_new_luet
branch
3 times, most recently
from
June 11, 2021 20:16
c9a3a09
to
736c021
Compare
Itxaka
changed the title
Use the new luet-mtree event for upgrade checks
[WIP]Use the new luet-mtree event for upgrade checks
Jun 15, 2021
Argh, recovery is failing due to the plugin probably! setting this to wip |
Itxaka
changed the title
[WIP]Use the new luet-mtree event for upgrade checks
Use the new luet-mtree event for upgrade checks
Jun 15, 2021
Itxaka
force-pushed
the
use_new_luet
branch
2 times, most recently
from
June 16, 2021 15:02
4d8366f
to
3bcbaf9
Compare
We were using a bash script to call luet-mtree on upgrade to check for valid mtree checksums. luet-mtree 0.0.6 now supports working with events from luet itself, which will do the same as the bash script and extract the image metadata to check the mtree checksums. This patch removes the old bash script and uses the luet-mtree plugin directly to check the checksums, it also bumps luet-mtree to 0.0.6 Signed-off-by: Itxaka <[email protected]>
davidcassany
approved these changes
Jun 21, 2021
frelon
pushed a commit
to frelon/elemental-toolkit
that referenced
this pull request
May 12, 2023
All source packages in config file for build-iso, have to be provided in uri format with prefix "dir", "file", "oci", "docker", "channel" (e.g. channel:live/grub2-efi-image) Fixes rancher#219 Signed-off-by: Michal Jura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a bash script to call luet-mtree on upgrade to check for
valid mtree checksums.
luet-mtree 0.0.6 now supports working with events from luet itself,
which will do the same as the bash script and extract the image metadata
to check the mtree checksums.
This patch removes the old bash script and uses the luet-mtree plugin
directly to check the checksums, it also bumps luet-mtree to 0.0.6
Signed-off-by: Itxaka [email protected]