Repository navigation
refactor(fsdp): rename sleep_wake.py to device_move.py - #273
Merged
Merged
Conversation
This was referenced Sep 28, 2026
Merged
Rockdu
added this pull request to stack #270
September 29, 2026 20:58
zhihengy
approved these changes
Oct 4, 2026
OnePunchMonk
pushed a commit
to OnePunchMonk/miles_diffusion
that referenced
this pull request
Oct 5, 2026
OnePunchMonk
pushed a commit
to OnePunchMonk/miles_diffusion
that referenced
this pull request
Oct 5, 2026
OnePunchMonk
pushed a commit
to OnePunchMonk/miles_diffusion
that referenced
this pull request
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 8/9 of follow-ups to #263:
main← #265 ← #266 ← #267 ← #268 ← #269 ← #271 ← #272 ← this ← #274.What
miles/backends/fsdp_utils/sleep_wake.pybecomesdevice_move.py, named after what it holds (move_model,move_optimizer, and the frozen-model sleep/wake built on them). Its GPU test and worker follow:test_device_move.py,_device_move_worker.py.Why
Other RL trainers name these helpers after the move (
offload_fsdp_model_to_cpuin verl,move_to_devicein NeMo-RL,move_torch_optimizerin miles);sleep/wake_upstay the actor's phase names, as in miles and slime. Renaming here instead of in #267 keeps the CI results of the PRs below.Checklist
pre-commit runpasses on the changed filespytest -xis green — CPU fsdp tests pass locally; the renamed GPU test is still registered onstage-b-5-gpu-h200python3 train.py --helpstill parses — n/a