Repository navigation
refactor(args): rename --ema-rollout-policy to --rollout-weights and document the role flags - #265
Merged
Merged
Conversation
This was referenced Sep 27, 2026
Rockdu
added this pull request to stack #270
September 27, 2026 17:59
This was referenced Sep 28, 2026
zhihengy
approved these changes
Oct 4, 2026
OnePunchMonk
pushed a commit
to OnePunchMonk/miles_diffusion
that referenced
this pull request
Oct 5, 2026
…document the role flags (radixark#265) * refactor(args): rename --ema-rollout-policy to --rollout-weights * docs: list the reference, teacher and actor-adapter flags in the CLI reference * docs(fsdp): drop a stale note about a removed snapshot manager
OnePunchMonk
pushed a commit
to OnePunchMonk/miles_diffusion
that referenced
this pull request
Oct 5, 2026
OnePunchMonk
pushed a commit
to OnePunchMonk/miles_diffusion
that referenced
this pull request
Oct 5, 2026
…document the role flags (radixark#265) * refactor(args): rename --ema-rollout-policy to --rollout-weights * docs: list the reference, teacher and actor-adapter flags in the CLI reference * docs(fsdp): drop a stale note about a removed snapshot manager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 1/9 of follow-ups to #263:
main← this ← #266 ← #267 ← #268 ← #269 ← #271 ← #272 ← #273 ← #274.What
--ema-rollout-policy {live,ema}to--rollout-weights {actor,ema}(supersedes refactor(args): rename --ema-rollout-policy to --rollout-weights #264).--ref-load,--ref-lora-adapter-path,--ref-cpu-offload,--teacher-load,--teacher-lora-adapter-path,--teacher-cpu-offload,--lora-adapter-pathand--ref-mode ref.docs/fsdp_model_roles.md.Why
The flag chooses which weights the rollout engines receive; "policy" and "live" did not say that.
Files
miles/utils/arguments.py,miles/backends/fsdp_utils/actor.py: the rename.docs/user-guide/cli-reference.md,docs/fsdp_model_roles.md, recipes: docs and flag spelling.Checklist
pre-commit run --all-filespasses — not run locallypytest -xis green — CPU tests touched by the rename pass locallypython3 train.py --helpstill parses — not run (needs the GPU image)