Repository navigation
perf(fsdp): skip deterministic NaN fill in moves; fix reference worker PYTHONPATH - #269
Merged
Merged
Conversation
This was referenced Sep 27, 2026
Merged
Rockdu
force-pushed
the
fsdp-followups/5-tests-infra
branch
from
September 27, 2026 11:07
b3d0324 to
de4c4db
Compare
Rockdu
force-pushed
the
fsdp-followups/5-tests-infra
branch
2 times, most recently
from
September 27, 2026 11:26
d7ff482 to
d6e2358
Compare
Rockdu
force-pushed
the
fsdp-followups/5-tests-infra
branch
from
September 27, 2026 13:06
d6e2358 to
f005e0a
Compare
Rockdu
added this pull request to stack #270
September 27, 2026 17:59
Rockdu
force-pushed
the
fsdp-followups/5-tests-infra
branch
from
September 27, 2026 18:10
f005e0a to
36317f3
Compare
Rockdu
force-pushed
the
fsdp-followups/5-tests-infra
branch
from
September 27, 2026 18:25
36317f3 to
f31f045
Compare
Rockdu
force-pushed
the
fsdp-followups/5-tests-infra
branch
2 times, most recently
from
September 27, 2026 19:09
2a4ce58 to
e682e56
Compare
Rockdu
force-pushed
the
fsdp-followups/5-tests-infra
branch
from
September 27, 2026 19:39
e682e56 to
84130a5
Compare
1 of 6 tasks
This was referenced Sep 28, 2026
zhihengy
approved these changes
Oct 4, 2026
OnePunchMonk
pushed a commit
to OnePunchMonk/miles_diffusion
that referenced
this pull request
Oct 5, 2026
…r PYTHONPATH (radixark#269) * test(fsdp): put the repository root on the reference worker's PYTHONPATH * perf(fsdp): skip deterministic mode's NaN fill for tensors a move overwrites
OnePunchMonk
pushed a commit
to OnePunchMonk/miles_diffusion
that referenced
this pull request
Oct 5, 2026
OnePunchMonk
pushed a commit
to OnePunchMonk/miles_diffusion
that referenced
this pull request
Oct 5, 2026
…r PYTHONPATH (radixark#269) * test(fsdp): put the repository root on the reference worker's PYTHONPATH * perf(fsdp): skip deterministic mode's NaN fill for tensors a move overwrites
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 5/9 of follow-ups to #263:
main← #265 ← #266 ← #267 ← #268 ← this ← #271 ← #272 ← #273 ← #274.What
PYTHONPATH, so it also runs outside CI (the worker imports the CPU test's harness fromtests). refactor(lora): one plain PEFT adapter directory per component #274 keeps the caller'sPYTHONPATHbehind it instead of replacing it.Not in this PR
sleep_wake.pystill reads the singularFSDPState._fsdp_param_group. The plural_fsdp_param_groupsexists only from torch 2.12, and the repo pins torch 2.11 (the Wan2.2 param-dtype patch refuses other versions), so the switch belongs to the torch upgrade.Files
miles/backends/fsdp_utils/sleep_wake.py:_skip_uninitialized_memory_fill.tests/fast-gpu/backends/fsdp_utils/test_reference_models.py: workerPYTHONPATH.Checklist
pre-commit run --all-filespasses — not run locallypytest -xis green — GPU tests run in CI onlypython3 train.py --helpstill parses — n/a