Drive the cell state machine through whole-cell transitions - #1885
Open
fzyzcjy wants to merge 1 commit into
Open
Drive the cell state machine through whole-cell transitions#1885fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-2
branch
from
July 28, 2026 13:31
c1cfca9 to
5f0435c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-1
branch
2 times, most recently
from
August 3, 2026 23:45
3fa06ea to
36a0815
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-2
branch
from
August 3, 2026 23:45
5f0435c to
202bd42
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-1
branch
from
August 4, 2026 00:39
36a0815 to
23d3301
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-2
branch
from
August 4, 2026 00:39
202bd42 to
2560c03
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-1
branch
from
August 4, 2026 06:58
23d3301 to
cb9631e
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:58
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-2
branch
2 times, most recently
from
August 6, 2026 07:03
fdec901 to
5c242d1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-1
branch
2 times, most recently
from
August 10, 2026 06:08
4c94b79 to
5d6d557
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-2
branch
2 times, most recently
from
August 10, 2026 16:07
a1724e8 to
9e05465
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-1
branch
2 times, most recently
from
August 10, 2026 16:34
673fee2 to
5bafef7
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-2
branch
from
August 10, 2026 16:34
9e05465 to
7ad1221
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-1
branch
from
August 12, 2026 02:48
5bafef7 to
44ade85
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-2
branch
from
August 12, 2026 02:48
7ad1221 to
3ae7202
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-1
branch
from
August 12, 2026 14:31
44ade85 to
ce85aa0
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-2
branch
from
August 12, 2026 14:31
3ae7202 to
9625673
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-2
branch
3 times, most recently
from
August 13, 2026 03:25
60b8e9f to
556d8ec
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-1
branch
from
August 13, 2026 03:25
3e2b85d to
5541f37
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-2
branch
from
August 13, 2026 06:01
556d8ec to
e7203e8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-1
branch
from
August 13, 2026 06:01
5541f37 to
a03824b
Compare
A cell's engines are the node-ranks of one distributed SGLang engine, so every state change now goes through a cell-level _mark_* helper that touches all of them. This is an equivalent refactor: it is a prerequisite for lifting the state machine onto ServerCell, and it makes the "all engines of a cell change state together" invariant explicit at each call site rather than implied by the loops. Squashed commits: - Drive the cell state machine through whole-cell transitions - Apply black auto-fix
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-1
branch
from
August 14, 2026 04:46
a03824b to
4744679
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op6-2
branch
from
August 14, 2026 04:46
e7203e8 to
2ad891c
Compare
guapisolo
approved these changes
Aug 25, 2026
guapisolo
left a comment
guapisolo
left a comment
Collaborator
There was a problem hiding this comment.
Approved in stack context: #1885 can leak staged actors on launch failure and its restart test is invalid, both fixed by #2112 with rollback, retry, and whole-cell restart coverage; #2115/#2175 further harden and cover the failure path. These fixes land before safe merge ckpt 1 (#2176) and remain through the checked chain tip #2649, so the findings no longer block this PR within the safe-merge range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837