Skip to content

chore(api/examples/fungible): bump drink version#562

Merged
evilrobot-01 merged 4 commits intomainfrom
chungquantin/api/fungible/chore-bump_example_drink
May 16, 2025
Merged

chore(api/examples/fungible): bump drink version#562
evilrobot-01 merged 4 commits intomainfrom
chungquantin/api/fungible/chore-bump_example_drink

Conversation

@chungquantin
Copy link
Copy Markdown
Contributor

Update to use the latest version of pop-drink that is bumped to stable2503, compatible with the current codebase of pop-node. Requires r0gue-io/pop-drink#30 to be merged first.

Comment thread pop-api/examples/fungibles/Cargo.toml Outdated
@chungquantin chungquantin self-assigned this May 8, 2025
@chungquantin
Copy link
Copy Markdown
Contributor Author

[sc-3716]

Comment thread .github/workflows/ci.yml
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.44%. Comparing base (8e5c719) to head (dff9758).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
- Coverage   63.56%   63.44%   -0.13%     
==========================================
  Files         121      121              
  Lines       23801    23850      +49     
  Branches    23801    23850      +49     
==========================================
+ Hits        15129    15131       +2     
- Misses       7628     7675      +47     
  Partials     1044     1044              

see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chungquantin chungquantin requested a review from a team May 12, 2025 07:01
Copy link
Copy Markdown
Member

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Comment thread .github/workflows/ci.yml
Comment thread pop-api/examples/fungibles/tests.rs Outdated
@chungquantin chungquantin requested a review from evilrobot-01 May 15, 2025 03:59
@evilrobot-01 evilrobot-01 merged commit 9cd371f into main May 16, 2025
18 checks passed
@evilrobot-01 evilrobot-01 deleted the chungquantin/api/fungible/chore-bump_example_drink branch May 16, 2025 06:16
chungquantin added a commit that referenced this pull request May 16, 2025
* chore(api/examples/fungible): bump drink version

* chore(ci): test contract in examples

* chore: update drink dependency branch

* chore: resolve review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants