Merged
Conversation
Author
|
[sc-3715] |
chungquantin
force-pushed
the
chungquantin/chore-stable2503
branch
from
ea6b8d5 to
7fb14f0
Compare
chungquantin
commented
May 6, 2025
al3mart
reviewed
May 6, 2025
Member
al3mart
left a comment
al3mart
left a comment
There was a problem hiding this comment.
Have done a quick review on the code changes and it looks good! Nothing to point out after a first look.
I'll do a final review as soon as possible.
Daanvdplas
approved these changes
May 8, 2025
al3mart
approved these changes
May 8, 2025
Member
al3mart
left a comment
al3mart
left a comment
There was a problem hiding this comment.
Happy to approve, changes seem perfectly reasonable.
I have left one comment about the fungible tests expecting devnet instead of testnet, which we should update so the new default config doesn't conflict with the tests.
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
pop-nodeis nearly ready for the stable2503, this PR is needed for the drink tests inexamples/fungiblesto work.