Skip to content

chore(api/examples/fungible): bump drink version #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evilrobot-01 merged 4 commits into from
May 16, 2025
Merged

chore(api/examples/fungible): bump drink version #562

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c90ee6d
chore(api/examples/fungible): bump drink version
chungquantin May 8, 2025
ccc6d98
chore(ci): test contract in examples
chungquantin May 8, 2025
80eaa45
chore: update drink dependency branch
chungquantin May 12, 2025
dff9758
chore: resolve review comments
chungquantin May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ jobs:
working-directory: pop-api
run: cargo test --release --locked --all-features

api-examples:
api-examples-tests:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -176,15 +176,15 @@ jobs:
- name: Install `cargo-contract`
run: cargo install --force --locked cargo-contract

- name: Check example contracts
- name: Test example contracts
working-directory: pop-api/examples
shell: bash
run: |
set -e
for example in */ ; do
if [ -d "$example" ]; then
echo "Checking contract in $example"
(cd "$example" && cargo contract check)
echo "Test contract in $example"
(cd "$example" && cargo test --release)
Comment thread
evilrobot-01 marked this conversation as resolved.
fi
done

Expand Down
2 changes: 1 addition & 1 deletion pop-api/examples/fungibles/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ pop-api = { path = "../../../pop-api", default-features = false, features = [
] }

[dev-dependencies]
drink = { package = "pop-drink", git = "https://github.com/r0gue-io/pop-drink" }
drink = { package = "pop-drink", git = "https://github.com/r0gue-io/pop-drink", branch = "chungquantin/chore-stable2503", features = [ "devnet" ] }
Comment thread
chungquantin marked this conversation as resolved.
Outdated
env_logger = { version = "0.11.3" }
serde_json = "1.0.114"

Expand Down
4 changes: 2 additions & 2 deletions pop-api/examples/fungibles/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use drink::{
devnet::{
account_id_from_slice,
error::{
v0::{ApiError::*, ArithmeticError::*, Error},
v0::{ApiError::*, ArithmeticError::*, Error, TokenError::UnknownAsset},
Assets,
AssetsError::*,
},
Expand Down Expand Up @@ -557,7 +557,7 @@ fn mint_fails_with_token_not_live(mut session: Session) {
// Token is not live, i.e. frozen or being destroyed.
assert_ok!(session.sandbox().start_destroy(&TOKEN));
// `pallet-assets` returns `AssetNotLive` error.
Comment thread
evilrobot-01 marked this conversation as resolved.
Outdated
assert_err!(mint(&mut session, ALICE, AMOUNT), Error::Module(Assets(AssetNotLive)));
assert_err!(mint(&mut session, ALICE, AMOUNT), Error::Raw(Token(UnknownAsset)));
}

#[drink::test(sandbox = Pop)]
Expand Down