Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type errors introduced when #2696 and #2700 were merged #2788

Merged
merged 4 commits into from
Sep 3, 2023
Merged

Fix type errors introduced when #2696 and #2700 were merged #2788

merged 4 commits into from
Sep 3, 2023

Conversation

CoolCat467
Copy link
Member

@CoolCat467 CoolCat467 commented Sep 3, 2023 •
edited
Loading

This PR aims to fix the type errors introduced in #2696 and #2700, while leaving the multierror fixes for #2787.

@codecov
Copy link

codecov bot commented Sep 3, 2023 •
edited
Loading

Codecov Report

Merging #2788 (dacd4b3) into master (8304dce) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2788   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files         113      113           
  Lines       16917    16919    +2     
  Branches     3049     3050    +1     
=======================================
+ Hits        16739    16741    +2     
  Misses        123      123           
  Partials       55       55
Files Changed Coverage Δ
trio/_threads.py 100.00% <ø> (ø)
trio/_core/_run.py 99.44% <100.00%> (+<0.01%) ⬆️
trio/_core/_tests/test_run.py 100.00% <100.00%> (ø)

@CoolCat467 CoolCat467 marked this pull request as ready for review September 3, 2023 05:22
@CoolCat467 CoolCat467 changed the title [WIP] Fix type errors introduced when #2696 and #2700 were merged Fix type errors introduced when #2696 and #2700 were merged Sep 3, 2023
A5rocks
A5rocks approved these changes Sep 3, 2023
View reviewed changes
Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fine, though nitpicks obviously...

I'll let someone else merge this (this isn't like emergency-level priority or anything :^)

trio/_core/_run.py Outdated Show resolved Hide resolved
@richardsheridan richardsheridan merged commit 4d19399 into master Sep 3, 2023
50 of 52 checks passed
@richardsheridan richardsheridan deleted the fix-2696-2700 branch September 3, 2023 14:28
@richardsheridan
Copy link
Contributor

Thank you!

@A5rocks A5rocks added the typing Adding static types to trio's interface label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A5rocks A5rocks A5rocks approved these changes

Assignees
No one assigned
Labels
typing Adding static types to trio's interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CoolCat467 @richardsheridan @A5rocks