-
-
Notifications
You must be signed in to change notification settings - Fork 353
Attempt to fix multierror typing #2787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2787 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 113 113
Lines 16919 16919
Branches 3050 3050
=======================================
Hits 16741 16741
Misses 123 123
Partials 55 55
|
I think the correct solution is to change |
I tried and it was annoying (some branch in my fork...) |
That sounds like a good idea, I'll start trying to do that now. |
It probably is fine if we add more ignores here, since it's deprecated anyway. Users should only be annotating/interacting with |
It's looking like it might not be possible to make |
I've given up attempting to make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this passes type checking and that the weird previous changes showing in the diff thing is fixed, this looks good to me.
Actually the merge looks quite messed up -- maybe reset to a clean state, rebase onto master, and copy over the type ignore deletion + new type ignore? |
57dcb3e
to
721bfca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
At the moment, this is only ignoring generics not matching properly in the subclass. If anyone has any better ideas on how to handle this, feel free to try it out.